Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

don't normalize paths in expand_path#1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Witcher01 wants to merge1 commit intopimutils:main
base:main
Choose a base branch
Loading
fromWitcher01:expand-path-no-normalize

Conversation

@Witcher01
Copy link

Remove normalizing paths in "expand_path" and expand environment variables. Paths don't need to be normalized, but doing this on non-path parameters (i.e. URLs) might cause bugs.

Reported-by: s-hamann
Closes:#1021

Remove normalizing paths in "expand_path" and expand environmentvariables. Paths don't need to be normalized, but doing this onnon-path parameters (i.e. URLs) might cause bugs.Reported-by: s-hamannCloses:pimutils#1021Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
@WhyNotHugo
Copy link
Member

I'd have to recall why we normalised paths in the first place. The initial commit isn't very helpful:da8bba8 But I have a vague impression that it makes a difference in some situations (e.g.: when a user-provided path is compared with an internally-generated path maybe?).

But yeah, we shouldn't normalise paths on URLs, that's outright wrong.

@Shadow53
Copy link

Looks like the readthedocs job is preventing this PR from being merged? It's saying the.readthedocs.yaml file can't be found in the repository, which I don't see onmain either.

Would like to see this merged as I am also running into this issue.

@WhyNotHugo
Copy link
Member

I reviewed this and#1021 a bit further.

If a password has$HOME, we'd still be messing it up. I think that we need to stop callingexpand_path on some types of fields.

@WhyNotHugo
Copy link
Member

Exactly which scenario does this patch fix?

@Shadow53
Copy link

Exactly which scenario does this patch fix?

For me, it's the path normalization issue. I use 1Password, and the cli command to get a password isop read op://<vault>/<item>/password. The URI bit gets normalized toop:/<vault>/..., which causes the command to fail.

I can use a script to hide the real command so this doesn't happen, but I'd rather that not be a long-term solution.

@Shadow53
Copy link

If a password has$HOME, we'd still be messing it up. I think that we need to stop callingexpand_path on some types of fields.

Since bothcommand andshell are supported, one possible option is to let the shell expand environment variables and havecommand pass all arguments verbatim.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

password.fetch command applies path normalization to non-path parameters

3 participants

@Witcher01@WhyNotHugo@Shadow53

[8]ページ先頭

©2009-2025 Movatter.jp