- Notifications
You must be signed in to change notification settings - Fork177
don't normalize paths in expand_path#1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Remove normalizing paths in "expand_path" and expand environmentvariables. Paths don't need to be normalized, but doing this onnon-path parameters (i.e. URLs) might cause bugs.Reported-by: s-hamannCloses:pimutils#1021Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
WhyNotHugo commentedApr 17, 2024
I'd have to recall why we normalised paths in the first place. The initial commit isn't very helpful:da8bba8 But I have a vague impression that it makes a difference in some situations (e.g.: when a user-provided path is compared with an internally-generated path maybe?). But yeah, we shouldn't normalise paths on URLs, that's outright wrong. |
Shadow53 commentedSep 28, 2024
Looks like the readthedocs job is preventing this PR from being merged? It's saying the Would like to see this merged as I am also running into this issue. |
WhyNotHugo commentedSep 28, 2024
I reviewed this and#1021 a bit further. If a password has |
WhyNotHugo commentedSep 28, 2024
Exactly which scenario does this patch fix? |
Shadow53 commentedSep 28, 2024
For me, it's the path normalization issue. I use 1Password, and the cli command to get a password is I can use a script to hide the real command so this doesn't happen, but I'd rather that not be a long-term solution. |
Shadow53 commentedSep 28, 2024
Since both |
Remove normalizing paths in "expand_path" and expand environment variables. Paths don't need to be normalized, but doing this on non-path parameters (i.e. URLs) might cause bugs.
Reported-by: s-hamann
Closes:#1021