NotificationsYou must be signed in to change notification settings
Fork177
Star1.7k

Commit5870a99

committed

Don't throw exceptions on unprocessed hrefs in get_multi

Rather, just log them. This allows my calendar sync to continue to workeven if some of the hrefs can't be retrieved. In my case, one of thehrefs on my calendar was always returning a 404, so I want to skip it.

1 parentc54d7fd commit5870a99Copy full SHA for 5870a99

File tree

1 file changed

-1

lines changed

vdirsyncer/storage
- dav.py

1 file changed

-1

lines changed

`‎vdirsyncer/storage/dav.py‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -547,7 +547,7 @@ async def get_multi(self, hrefs):`
`547`	`547`	`else:`
`548`	`548`	`rv.append((href,Item(raw),etag))`
`549`	`549`	`forhrefinhrefs_left:`
`550`		`-raiseexceptions.NotFoundError(href)`
	`550`	`+dav_logger.warning(f"Skipping{href}, not found")`
`551`	`551`
`552`	`552`	`forhref,item,etaginrv:`
`553`	`553`	`yieldhref,item,etag`
`@@ -645,6 +645,7 @@ def _parse_prop_responses(self, root, handled_hrefs=None):`
`645`	`645`	`props=response.findall("{DAV:}propstat/{DAV:}prop")`
`646`	`646`	`ifpropsisNoneornotlen(props):`
`647`	`647`	`dav_logger.debug(f"Skipping{href!r}, properties are missing.")`
	`648`	`+dav_logger.debug(f"Response for{href!r}:{etree.tostring(response)}")`
`648`	`649`	`continue`
`649`	`650`	`else:`
`650`	`651`	`props=_merge_xml(props)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5870a99

File tree

1 file changed

1 file changed

`‎vdirsyncer/storage/dav.py‎`

0 commit comments