Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork437
Add original path to error messages#363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b25a26b to3f25805Compare| */ | ||
| function errorMessage(message: string, originalPath: string | undefined) { | ||
| if (originalPath) { | ||
| return `${message}: ${originalPath}; visit ${DEBUG_URL} for more info`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not tied to this format, happy to get other opinions. Another PR used${originalPath}: ${message} format instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Can we move forward and make a release for this? this really helps a lot with migrating from Express 4 to Express 5 |
Closes#336,#358,#356, and#354.
Adds
originalPathtoTokenData, which will be used (when available) for the error messages. It's already added to any methods that input a string.