Improve error messages by including the path#356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

simhnna wants to merge1 commit intopillarjs:master

base:master

Choose a base branch

fromsimhnna:include-path-in-error-messages

Open

Improve error messages by including the path#356

simhnna wants to merge1 commit intopillarjs:masterfromsimhnna:include-path-in-error-messages

Conversation

Copy link

Contributor

simhnna commentedApr 7, 2025

Tried a couple of different places to include the path in the error message and I think prepending it is the easiest to read but if you'd like it somewhere else I'd update accordingly

blakeembrey reviewed

Apr 29, 2025

View reviewed changes

Copy link

Member

blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I appreciate this PR, it's a great direction! However I think it'd be good to avoid usingstringify as it can output a different path to the original input, and instead add aoriginalPath or something toTokenData. I can open a PR you can review if that's OK?