Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork219
perf: optimize Python to QPDF object conversion#711
Open
qooxzuub wants to merge 1 commit intopikepdf:mainfrom
Open
perf: optimize Python to QPDF object conversion#711qooxzuub wants to merge 1 commit intopikepdf:mainfrom
qooxzuub wants to merge 1 commit intopikepdf:mainfrom
Conversation
ContributorAuthor
qooxzuub commentedFeb 4, 2026
"Benchmark" results: |
Refactor objecthandle_encode to use type dispatch via Py_TYPEpointer comparisons, replacing py::isinstance templates.- Implement fast-path string encoding via PyUnicode_AsUTF8AndSize.- Add support for decimal.Decimal with configurable precision via get_decimal_precision().- Optimize array_builder with pre-allocation via result.reserve().- Use leaky static singletons for decimal module attributes to avoid repeated imports and interpreter shutdown races.- Restore consistent ValueError strings for non-finite floats.
a622eb7 to43f750dCompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #711 +/- ##==========================================- Coverage 93.64% 93.64% -0.01%========================================== Files 60 60 Lines 6938 6936 -2 Branches 391 393 +2 ==========================================- Hits 6497 6495 -2 Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the performance of creating PDF objects from Python types, specifically within dictionary and array builders. Benchmarks show a reduction in dictionary creation time from ~4.2s to ~1.7s (~60% speedup).
Changes: