Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Modal improvements#503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Atmos4 wants to merge1 commit intopicocss:main
base:main
Choose a base branch
Loading
fromAtmos4:main
Open

Modal improvements#503

Atmos4 wants to merge1 commit intopicocss:mainfromAtmos4:main

Conversation

Atmos4
Copy link

Scrolling improvements

  • overflow on modal instead of article
  • prevent body overflow when modal is open

Animations

  • animations on open and close.Uses allow-discrete to prevent the modal from being focusable when closed. Browser support is low but non-support will just result in graceful degradation (no animation on closing modal).

This PR is more of a POC. I can split it into 2 PRs, one for the scrolling and one for the animations.

I am also unsure which animations I should include. Maybe it is just safer to explain in the docs how to add animations easily rather than enforcing specific animations.

pietz, micchickenburger, ej52, and mediaformat reacted with thumbs up emoji
- overflow on modal instead of article- animations- prevent body overflow when open modal
@lucaslarroche
Copy link
Member

@Atmos4, thanks a lot! And sorry for the delay.

I like the change to move overflow to the modal instead of the inner article. We can keep everything in one PR.

I wasn’t familiar withallow-discrete — does it allow entry and exit animations without JS? (Ref:modal.js)

For animations, we should stick to the existing ones defined in the utility classes:.modal-is-opening and.modal-is-closing.

@DNWEIJ
Copy link

I cannot contribute, but it would be a shame if this PR isn't pushed forward... :-(

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Atmos4@lucaslarroche@DNWEIJ
[8]ページ先頭
©2009-2025 Movatter.jp