Commit5c85200

committed

Understand == between ConstantScalarType

1 parent6bf335c commit5c85200Copy full SHA for 5c85200

File tree

+14

-2

lines changed

+14

-2

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2358,6 +2358,10 @@ private function resolveEqualType(Type $leftType, Type $rightType): BooleanType`
`2358`	`2358`	`return$this->resolveIdenticalType($leftType,$rightType);`
`2359`	`2359`	`}`
`2360`	`2360`
	`2361`	`+if ($leftTypeinstanceof ConstantScalarType &&$rightTypeinstanceof ConstantScalarType) {`
	`2362`	`+returnnewConstantBooleanType($leftType->getValue() ==$rightType->getValue());// phpcs:ignore`
	`2363`	`+}`
	`2364`	`+`
`2361`	`2365`	`if ($leftTypeinstanceof ConstantArrayType &&$rightTypeinstanceof ConstantArrayType) {`
`2362`	`2366`	`return$this->resolveConstantArrayTypeComparison($leftType,$rightType,fn ($leftValueType,$rightValueType):BooleanType =>$this->resolveEqualType($leftValueType,$rightValueType));`
`2363`	`2367`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,8 @@ public function doFoo(string $s): void`
`15`	`15`	`assertType('false', [1] != [1]);`
`16`	`16`	`assertType('false', [1] == [2]);`
`17`	`17`	`assertType('true', [1] != [2]);`
`18`		`-assertType('bool', [1] == ["1"]);`
`19`		`-assertType('bool', [1] != ["1"]);`
	`18`	`+assertType('true', [1] == ["1"]);`
	`19`	`+assertType('false', [1] != ["1"]);`
`20`	`20`
`21`	`21`	`assertType('false', [1] === [2]);`
`22`	`22`	`assertType('false', [1] !== [1]);`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,14 @@ public function testRule(): void`
`92`	`92`	`'Call to method ImpossibleMethodCall\Foo::isNotSame() with array{1, 3} and array{1, 3} will always evaluate to false.',`
`93`	`93`	`122,`
`94`	`94`	`],`
	`95`	`+[`
	`96`	`+'Call to method ImpossibleMethodCall\Foo::isSame() with array{\'a\',\'b\'} and array{1, 2} will always evaluate to false.',`
	`97`	`+139,`
	`98`	`+],`
	`99`	`+[`
	`100`	`+'Call to method ImpossibleMethodCall\Foo::isNotSame() with array{\'a\',\'b\'} and array{1, 2} will always evaluate to true.',`
	`101`	`+142,`
	`102`	`+],`
`95`	`103`	`[`
`96`	`104`	`'Call to method ImpossibleMethodCall\Foo::isSame() with\'\' and\'\' will always evaluate to true.',`
`97`	`105`	`174,`

Comments

(0)