NotificationsYou must be signed in to change notification settings
Fork2.2k
Star10.2k

Commitc139de3

committed

We don't need to use a ranom value for our ECHO liveness challenge.

A microsecond resolution timestamp combined with a monotonicallyincremented counter should be sufficient.This also fixes PHP 8.4 compilation as PHP 8.4 doesn't seem to have`php_rand()`.

1 parentdab6a62 commitc139de3Copy full SHA for c139de3

File tree

1 file changed

-1

lines changed

library.c

1 file changed

-1

lines changed

`‎library.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2886,11 +2886,13 @@ redis_sock_create(char *host, int host_len, int port,`
`2886`	`2886`	`}`
`2887`	`2887`
`2888`	`2888`	`staticintredis_uniqid(char*buf,size_tbuflen) {`
	`2889`	`+staticunsigned longcounter=0;`
`2889`	`2890`	`structtimevaltv;`
	`2891`	`+`
`2890`	`2892`	`gettimeofday(&tv,NULL);`
`2891`	`2893`
`2892`	`2894`	`returnsnprintf(buf,buflen,"phpredis:%08lx%05lx:%08lx",`
`2893`		`- (long)tv.tv_sec, (long)tv.tv_usec,(long)php_rand());`
	`2895`	`+ (long)tv.tv_sec, (long)tv.tv_usec,counter++);`
`2894`	`2896`	`}`
`2895`	`2897`
`2896`	`2898`	`staticintredis_stream_liveness_check(php_stream*stream) {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc139de3

File tree

1 file changed

1 file changed

`‎library.c‎`

0 commit comments