- Notifications
You must be signed in to change notification settings - Fork20
Migration of ZString, ZArray, ZObject to EBox#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ve unused Drop implementation
…nts in multiple files
9e1f1d0
intophper-framework:master 22 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This pull request introduces significant refactoring across multiple components of the codebase to enhance memory management, improve type safety, and simplify the implementation of core structures. Key changes include transitioning to the
EBox
smart pointer for memory management, streamlining object and array handling, and updating type conversions for better compatibility with the Zend Engine.Memory Management Improvements:
EBox<T>
inphper/src/alloc.rs
as a smart pointer for PHP values allocated in Zend Engine memory, replacing manual memory management. It handles deallocation automatically and provides safe access to PHP resources.ZObject
andStateObject<T>
inphper/src/objects.rs
to useEBox<T>
for memory management, simplifying their implementation and ensuring proper cleanup.[1][2]Array Handling Enhancements:
ZArray
inphper/src/arrays.rs
to useEBox<ZArr>
for memory management, replacing manual pointer handling and improving safety.[1][2]Drop
implementation forZArr
to ensure proper memory cleanup when arrays are destroyed.Type Conversion Updates:
phper/src/classes.rs
,phper/src/functions.rs
, andphper/src/objects.rs
.[1][2][3]Test Improvements:
Documentation and Cleanup:
ebox!
macro and associatedEBox
implementation fromphper-alloc/src/lib.rs
andphper-alloc/src/macros.rs
. These have been replaced with the newEBox
implementation inphper/src/alloc.rs
.[1][2]ZObject
andStateObject<T>
to reflect their new implementations usingEBox
.[1][2]