Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork151
Porting RPC commands to LSP#2782
-
Do you believe it would be beneficial and also simply possible to port existing RPC commands to LSP protocol as code actions? As I view it, this might contribute to easier access to particular actions without need for editor plugins like phpactor.nvim. Although I am not sure how it would affect the readability of code actions menu (there would be much more actions too choose from at request), and how does amount of code action providers affect the performance of phpactor (I personaly notice a delay when initiating a code actions menu from nvim). |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 1 comment 2 replies
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
which actions do you have in mind? all the code transformations are in the LSP. class moving isnot (mainly because it works in a whole different way) and maybe one or two others but there is practically only one or two concrete reasons ot use the "RPC" system, it's 95% obsolete. |
BetaWas this translation helpful?Give feedback.
All reactions
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
-
Hmm... I might blindly assumed, that all actions listed inphpactor.nvim are missing LSP implementation. Namely: But it seems it is only true for |
BetaWas this translation helpful?Give feedback.
All reactions
-
yeah, some of thoseare LSP actions. fwiw the ones that have no direct counterpart:
|
BetaWas this translation helpful?Give feedback.