- Notifications
You must be signed in to change notification settings - Fork370
Add posibility to restart workers immediately after TTL will expire#553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
zwirek wants to merge4 commits intophp-pm:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
andig commentedAug 27, 2022
I think we should do this without an additional parameter. The jitter definitely makes sense. |
Author
zwirek commentedAug 29, 2022
I've amended the code as you suggested. I've removed additional parameter and now workers will be restarted as soon as possible when ttl expire |
Contributor
andig commentedAug 29, 2022
Would appreciate a PR review. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed that when ttl is set and expired then all workers are restarted in the same time. This causes bigger lag with response from ppm. It is bigger problem when bootstrap of application is heavy.
My proposal is to add another strategy to handle workers restart when ttl will expire. Workers will be restarted immediately after ttl will expire +/-5 sec. This should keep workers fresh and should prevent workers from restarting at the same time.
To enable this behavior
ttl-restart-strategycli parameter or config parameter need to be set onexpire. By default ppm will restart workers due to ttl expiration only when request will be received. As it is handled in current implementation.