I don't know why the Symfony error handler is always enabled. Maybe there is a deeper meaning behind it that I don't see. But if not, I propose to only useDebug when debugging is requested (via config or command option).

Only enable symfony error handler in debug mode

7bec0ef

Copy link

Contributor

acasademont commentedAug 10, 2020

Not so sure about this one, if the server crashes (during the bridge bootstrap, for example) there might be very little info about what happened. Did you run some tests on it?

Copy link

ContributorAuthor

jkrzefski commentedAug 10, 2020

No, I did not run any tests on my end. I only looked through the code, spotted this and thought it looked wrong. The travis build seems fine, though.

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

Copy link

Contributor

andig commentedAug 12, 2020

Enable during startup and disable after first client answer sent?

Copy link

Contributor

andig commentedJan 8, 2022

I am totally ok with leaving it the way it was. I would merely like a short explanation on why the error handler is enabled in production. Maybe a comment in the code would be nice, so others don't get confused like I was.

Could you propose what you'd expect?