- Notifications
You must be signed in to change notification settings - Fork821
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:php-curl-class/php-curl-class
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:11.0.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:php-curl-class/php-curl-class
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:11.0.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 3commits
- 7files changed
- 2contributors
Commits on Feb 20, 2025
Increase psalm strictness (#925)
* Fix PossiblyUndefinedArrayOffsetERROR: PossiblyUndefinedArrayOffset - ../src/Curl/Curl.php:1890:28 -Possibly undefined array key (seehttps://psalm.dev/167) list($key, $value) = explode(':', $raw_headers[$i], 2);* Fix PossiblyUndefinedArrayOffsetERROR: PossiblyUndefinedArrayOffset - ../src/Curl/Curl.php:1034:28 -Possibly undefined array key (seehttps://psalm.dev/167) list($key, $value) = explode(':', $header, 2);* Fix PossiblyUndefinedArrayOffsetERROR: PossiblyUndefinedArrayOffset - ../src/Curl/MultiCurl.php:465:28 -Possibly undefined array key (seehttps://psalm.dev/167) list($key, $value) = explode(':', $header, 2);* Fix PossiblyInvalidOperandERROR: PossiblyInvalidOperand - ../src/Curl/Curl.php:1407:69 - Cannotconcatenate with a int<0, max>|string (seehttps://psalm.dev/163) echo 'Response content length (calculated): ' . $response_calculated_length . "\n";* Fix PossiblyInvalidArgumentERROR: PossiblyInvalidArgument - ../src/Curl/BaseCurl.php:408:34 -Argument 2 of define expects array<array-key, mixed>|null|scalar, butpossibly different type false|resource provided (seehttps://psalm.dev/092) define('STDERR', fopen('php://stderr', 'wb'));* Fix ArgumentTypeCoercionERROR: ArgumentTypeCoercion - ../src/Curl/MultiCurl.php:956:16 -Argument 1 of usleep expects int<0, max>, but parent type int provided(seehttps://psalm.dev/193) usleep((int) $sleep_seconds * 1000000);* Fix PossiblyFalseArgumentERROR: PossiblyFalseArgument - ../src/Curl/MultiCurl.php:131:50 -Argument 2 of file_put_contents cannot be false, possiblyarray<array-key, string>|resource|string value expected (seehttps://psalm.dev/104) file_put_contents($filename, stream_get_contents($fh));* Fix PossiblyFalseArgumentERROR: PossiblyFalseArgument - ../src/Curl/Curl.php:437:49 - Argument 2of stream_copy_to_stream cannot be false, possibly resource valueexpected (seehttps://psalm.dev/104) stream_copy_to_stream($tmpfile, $fh);ERROR: PossiblyFalseArgument - ../src/Curl/Curl.php:438:24 - Argument 1of fclose cannot be false, possibly resource value expected (seehttps://psalm.dev/104) fclose($fh);* Fix PossiblyFalseArgumentERROR: PossiblyFalseArgument - ../src/Curl/Curl.php:463:49 - Argument 2of stream_copy_to_stream cannot be false, possibly resource valueexpected (seehttps://psalm.dev/104) stream_copy_to_stream($file_handle, $main_file_handle);ERROR: PossiblyFalseArgument - ../src/Curl/Curl.php:468:16 - Argument 1of fclose cannot be false, possibly resource value expected (seehttps://psalm.dev/104) fclose($main_file_handle);* Fix PossiblyFalseArgumentERROR: PossiblyFalseArgument - ../src/Curl/Curl.php:1891:36 - Argument 1of count cannot be false, possibly Countable|array<array-key, mixed>value expected (seehttps://psalm.dev/104) $raw_headers_count = count($raw_headers);ERROR: PossiblyInvalidArrayAccess - ../src/Curl/Curl.php:1893:24 -Cannot access array value on non-array variable $raw_headers of typefalse (seehttps://psalm.dev/109) if (strpos($raw_headers[$i], ':') !== false) {* Fix PossiblyInvalidArgumentERROR: PossiblyInvalidArgument - ../src/Curl/Curl.php:1868:30 - Argument2 of define expects array<array-key, mixed>|null|scalar, but possiblydifferent type false|resource provided (seehttps://psalm.dev/092) define('STDOUT', fopen('php://stdout', 'w'));* Update psalm baseline
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff 11.0.3...11.0.4
Uh oh!
There was an error while loading.Please reload this page.