- Notifications
You must be signed in to change notification settings - Fork7.9k
Bug #68669DateTime::createFromFormat() does not allow NULL $timezone#1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Makes sense to me. |
when I was trying to merge this patch, I found this is already be fixed in master by Sara in365f428 |
Since this targets an unsupported branch of PHP, and since the issue is already fixed in a supported branch anyway, I'm closing this PR. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateTime::createFromFormat($format, $time, DateTimeZone $timezone = null)has a default value for its third parameter$timezone, but it doesn't acceptnullas a value.Running the following script will raise a warning:
DateTime::createFromFormat('Y/m/d', '2015/1/1', null);
// Warning: DateTime::createFromFormat() expects parameter 3 to be DateTimeZone, null given
While the documentation states that the default timezone is going to be used when no parameter is given, also the case where a
null$timezoneis given should be handled correctly.This would align the API to the language semantics about default values.