- Notifications
You must be signed in to change notification settings - Fork8k
Fix reentrant functions declarations checks#14315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes incompatible pointer type warnings during the reentrantfunctions declaration checks. These were not declared on some obsoletesystems if _REENTRANT was not defined. The check is for now left in thecode base but can be transitioned to newer code without checking formissing declarations or using these otherwise in the future.
I think so too. |
arnaud-lb approved these changesMay 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes incompatible pointer type warnings during the reentrant functions declaration checks. These were not declared on some obsolete systems if
_REENTRANTwas not defined. The check is for now left in the code base but can be transitioned to newer code without checking for missing declarations or using these otherwise in the future.Perhaps this should also go to PHP-8.2 since the
voidaddition attempted to fix some other warnings and errors (-Wstrict-prototypes). This AC_CHECK_DECL should work ok for all those issues.