Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1#13922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
arnaud-lb merged 1 commit intophp:PHP-8.2fromarnaud-lb:sysconf-max
Jun 24, 2024

Conversation

arnaud-lb
Copy link
Member

@arnaud-lbarnaud-lb commentedApr 9, 2024
edited
Loading

sysconf() can return -1 for _SC_GETPW_R_SIZE_MAX and related configuration. This is allowed by posix and is not necessarily an error. In particular, musl always returns -1.

This is a followup of#13921

Copy link
Member

@devnexendevnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense. That might not only solve musl but also an old FreeBSD issue if I recall well.

@arnaud-lb
Copy link
MemberAuthor

Closing this one in favor of#13876

@arnaud-lb
Copy link
MemberAuthor

Reopening because#13876 has stalled.

@arnaud-lbarnaud-lb marked this pull request as ready for reviewJune 11, 2024 17:49
@arnaud-lbarnaud-lb requested a review frombukka as acode ownerJune 11, 2024 17:49
@arnaud-lbarnaud-lb changed the base branch frommaster toPHP-8.2June 12, 2024 12:38
@arnaud-lb
Copy link
MemberAuthor

Changed the target branch to PHP-8.2, like#13921. I will merge if there is a new approval, since this was only approved for master.

@arnaud-lb
Copy link
MemberAuthor

@devnexen@bukka do you approve merging this in 8.2 ?

@devnexen
Copy link
Member

Yes. At first glance it looks like feature improvement, but it s a fix as for me.

arnaud-lb reacted with thumbs up emoji

@arnaud-lbarnaud-lb merged commit3fbca7f intophp:PHP-8.2Jun 24, 2024
arnaud-lb added a commit that referenced this pull requestJun 24, 2024
arnaud-lb added a commit that referenced this pull requestJun 24, 2024
* PHP-8.2:  [ci skip] NEWS forGH-13922  Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 (#13922)
arnaud-lb added a commit that referenced this pull requestJun 24, 2024
arnaud-lb added a commit that referenced this pull requestJun 24, 2024
* PHP-8.3:  [ci skip] NEWS forGH-13922  [ci skip] NEWS forGH-13922  Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 (#13922)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@devnexendevnexendevnexen approved these changes

@bukkabukkaAwaiting requested review from bukkabukka is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@arnaud-lb@devnexen

[8]ページ先頭

©2009-2025 Movatter.jp