Commit2b6e0ee

authored

Do not triggerreturn_value_from_void_function in initializers (realm#5429)

1 parentfc2a18e commit2b6e0eeCopy full SHA for 2b6e0ee

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,9 @@`
`134`	`134`	`[SimplyDanny](https://github.com/SimplyDanny)`
`135`	`135`	`[#3852](https://github.com/realm/SwiftLint/pull/3852)`
`136`	`136`
	`137`	+* Don't trigger the`return_value_from_void_function` warning from initializers.
	`138`	`+[mrbkap](https://github.com/mrbkap)`
	`139`	`+`
`137`	`140`	`##0.54.0: Macro-Economic Forces`
`138`	`141`
`139`	`142`	`####Breaking`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ private extension Syntax {`
`57`	`57`	`return node`
`58`	`58`	`}`
`59`	`59`
`60`		`-ifself.is(ClosureExprSyntax.self) \|\|self.is(VariableDeclSyntax.self){`
	`60`	`+ifself.is(ClosureExprSyntax.self) \|\|self.is(VariableDeclSyntax.self)\|\|self.is(InitializerDeclSyntax.self){`
`61`	`61`	`returnnil`
`62`	`62`	`}`
`63`	`63`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,17 @@ internal struct ReturnValueFromVoidFunctionRuleExamples {`
`45`	`45`	`}`
`46`	`46`	`"""),`
`47`	`47`	`Example("""`
	`48`	`+ func baz() {`
	`49`	`+ enum Foo {`
	`50`	`+ case bar`
	`51`	`+`
	`52`	`+ init?(arg: String?) {`
	`53`	`+ return nil`
	`54`	`+ }`
	`55`	`+ }`
	`56`	`+ }`
	`57`	`+""", excludeFromDocumentation:true),`
	`58`	`+Example("""`
`48`	`59`	`func test() {`
`49`	`60`	`guard condition else {`
`50`	`61`	`return`

Comments

(0)