NotificationsYou must be signed in to change notification settings
Fork87
Star476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Fix #209 - Handle static:: calls for static methods in partial mocks#305

Open

fkalinski wants to merge1 commit intophake:master

base:master

Choose a base branch

fromfkalinski:master

Open

Fix #209 - Handle static:: calls for static methods in partial mocks#305

fkalinski wants to merge1 commit intophake:masterfromfkalinski:master

Conversation

Copy link

fkalinski commentedNov 30, 2021

An attempt do deal with mocking static methods in partial mocks so static:: access to the methods works.

Fixphake#209- Handle static:: calls for static methods in partial m…

90864ff

…ocks

martinbutt mentioned this pull request

Jan 12, 2022

Static methods of a partial mock return NULL#209

Open

adoy force-pushed themaster branch from8ca1fdd tocb0f135Compare

January 22, 2022 02:16

adoy reviewed

Jan 23, 2022

View reviewed changes

src/Phake/Facade.php

		$mockGenerator->generate($newClassName, $mockedClassList, $this->infoRegistry);

		$this->cachedClasses[implode('__', $mockedClassList)] = $newClassName;
		if ($cache) {

Copy link

Member

adoyNov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As I understand your patch you are always regenerating a newclass everytime you're using thepartialMock method. This may lead to a bigger memory consumption.

Would it make sense to only cache two différent versions of the mocked class ? One forPhake::mock() and one forPhake::partialMock() ?