- Notifications
You must be signed in to change notification settings - Fork904
Add configurable boolean-to-numeric conversion for ResultSet getters#3796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+231 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f0cd9f9 tobe922a5Comparebe922a5 to08d81eeCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The conversions by ResultSet getter methods says get Float, Double, and BigDecimal should support this |
f31fa6d to6c62941CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
6664264 to9bbf8eeCompare@davecramer Made the changes. One SSL-related test on CI is failing. Not sure about it. |
a3be9d5 intopgjdbc:master 15 of 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull requestSep 19, 2025
| Package | Type | Package file | Manager | Update | Change ||---|---|---|---|---|---|| [org.postgresql:postgresql](https://jdbc.postgresql.org)([source](https://github.com/pgjdbc/pgjdbc)) | dependencies |misk/gradle/libs.versions.toml | gradle | patch | `42.7.7` -> `42.7.8` ||[com.google.apis:google-api-services-cloudkms](http://nexus.sonatype.org/oss-repository-hosting.html)([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`v1-rev20250818-2.0.0` -> `v1-rev20250911-2.0.0` ||[org.assertj:assertj-core](https://assertj.github.io/doc/#assertj-core)([source](https://github.com/assertj/assertj)) | dependencies |misk/gradle/libs.versions.toml | gradle | patch | `3.27.4` -> `3.27.5` || [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:s3](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` ||[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)| dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` || [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.33.12` -> `2.33.13` |---### Release Notes<details><summary>pgjdbc/pgjdbc (org.postgresql:postgresql)</summary>###[`v42.7.8`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#4278-2025-09-18)##### Added- feat: Add configurable boolean-to-numeric conversion for ResultSetgetters [PR #​3796](pgjdbc/pgjdbc#3796)##### Changed- perf: remove QUERY\_ONESHOT flag when calling getMetaData [PR#​3783](pgjdbc/pgjdbc#3783)- perf: use `BufferedInputStream` with `FileInputStream` [PR#​3750](pgjdbc/pgjdbc#3750)- perf: enable server-prepared statements for DatabaseMetaData##### Fixed- fix: avoid NullPointerException when cancelling a query if cancel keyis not known yet- fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"[PR #​3774](pgjdbc/pgjdbc#3774)- fix: traverse the current dimension to get the correct pos inPgArray#calcRemainingDataLength [PR#​3746](pgjdbc/pgjdbc#3746)- fix: make sure getImportedExportedKeys returns columns in consistentorder- fix: Add "SELF\_REFERENCING\_COL\_NAME" field to getTables'ResultSetMetaData to fix NullPointerException [PR#​3660](pgjdbc/pgjdbc#3660)- fix: unable to open replication connection to servers < 12- fix: avoid closing statement caused by driver's internalResultSet#close()- fix: return empty metadata for empty catalog names as it was before- fix: Incorrect class comparison in PGXmlFactoryFactory validation</details>---### Configuration📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2amevery weekday" in timezone Australia/Melbourne, Automerge - At any time(no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[config help](https://github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [RenovateBot](https://github.com/renovatebot/renovate).GitOrigin-RevId: 60823b502aee625ad34c64abe2d25a884fd81fee
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Addresses:#367
Problem:
When calling numeric getters (getByte(), getInt(), getLong(), getShort(), getFloat(), getDouble(), getBigDecimal()) on PostgreSQL boolean columns, the driver
throws PSQLException: Bad value for type byte : f.
Solution:
Added a new connection property
convertBooleanToNumericthat enables automatic conversion of PostgreSQL boolean values to numeric types:Usage:
// JDBC URL
jdbc:postgresql://host:5432/db?convertBooleanToNumeric=true
// HikariCP
config.addDataSourceProperty("convertBooleanToNumeric", "true");
// Spring Boot
spring.datasource.hikari.data-source-properties.convertBooleanToNumeric=true
Backward Compatibility:
All Submissions:
New Feature Submissions:
./gradlew styleCheckpass ?Changes to Existing Features: