- Notifications
You must be signed in to change notification settings - Fork904
Fix PgDatabaseMetaData implementation of catalog as param and return value#3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+875 −316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ocess catalog parameter and return catalog metadata per JDBC spec
| +" OR schema_name = replace((pg_catalog.current_schemas(true))[1], 'pg_temp_', 'pg_toast_temp_')) "; | ||
| if (catalog !=null) { | ||
| if (catalog.isEmpty()) { | ||
| sql +=" AND false "; |
Contributor
svendiedrichsenSep 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not ignore this case like the NULL case? And if ignore it like NULL you can simplify the whole if like in the schemaPattern if below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ifcatalog is"", then getSchemas should return schemas "without a catalog" perJDBC spec:
catalog - a catalog name; must match the catalog name as it is stored in the database;"" retrieves those without a catalog; null means catalog name should not be used to narrow down the search.
| +" WHERE nspname <> 'pg_toast' AND (nspname !~ '^pg_temp_' " | ||
| +" OR nspname = (pg_catalog.current_schemas(true))[1]) AND (nspname !~ '^pg_toast_temp_' " | ||
| +" OR nspname = replace((pg_catalog.current_schemas(true))[1], 'pg_temp_', 'pg_toast_temp_')) "; | ||
| sql ="SELECT schema_name AS\"TABLE_SCHEM\", catalog_name AS\"TABLE_CATALOG\" FROM information_schema.schemata " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
as appealing as it is to use theinformation schema, this is actually a view and adds another select into this query. Is there any reason to do this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed
…n) to process catalog parameter and return catalog metadata per JDBC spec"This reverts commite8ecbef.
…n_schema.sql_identifier in getSchemas
…stead of being ignored per JDBC spec
I removed the empty string check for
Please approve. |
…ssert TABLE_CATALOG in ResultSet is not null
I have added new tests and updated the existing test. |
Mapping the catalog name to the database name is already canonical in postgres itself, because when I SELECT current_database()::information_schema.sql_identifierAS catalog_name,n.nspname::information_schema.sql_identifierAS schema_name,u.rolname::information_schema.sql_identifierAS schema_owner,NULL::name::information_schema.sql_identifierAS default_character_set_catalog,NULL::name::information_schema.sql_identifierAS default_character_set_schema,NULL::name::information_schema.sql_identifierAS default_character_set_name,NULL::character varying::information_schema.character_dataAS sql_pathFROM pg_namespace n, pg_authid uWHEREn.nspowner=u.oidAND (pg_has_role(n.nspowner,'USAGE'::text)OR has_schema_privilege(n.oid,'CREATE, USAGE'::text)); An alternative to using |
…C implementation convention of other databases
…ications in DatabaseMetaData interface
@SophiahHo I don't think in the case of PostgreSQL there will ever be a situation where a connection can access another database. |
@davecramer I added a comment on#3389 to explain that9ea59bd added partial support for catalogs and broke things. |
@davecramer When our enterprise customers upgraded their pgjdbc driver from a version older than 42.7.0 to a version between 42.7.0 and 42.7.4, they are gettingduplicated database objects for metadata queries. As a workaround, we asked our enterprise customers to downgrade their pgjdbc driver to a version before 42.7.0. This MR fixes this bug so that our enterprise users would be able to use the latest pgjdbc driver with security updates. |
Uh oh!
There was an error while loading.Please reload this page.
Once we fix the code can you also do the release notes for this please |
@davecramer Do you mean run |
No, I mean explain what the changes are in the commit message. Thanks! |
Changes:
|
Uh oh!
There was an error while loading.Please reload this page.
I'd still be curious who the company is ? |
17cac52 intopgjdbc:master 17 of 18 checks passed
Uh oh!
There was an error while loading.Please reload this page.
@davecramer Thanks for merging. I work atPrecisely. |
You are welcome, thanks for hanging in there :) |
2 tasks
This was referencedFeb 11, 2025
Closed
vnobo commentedFeb 21, 2025
Very slow, very slow, for this investigation for a day, it is here |
Please, please elaborate. I have no idea what you are trying to say here ? |
kdebski85 commentedFeb 25, 2025
1 task
wendigo added a commit to trinodb/trino that referenced this pull requestMay 16, 2025
Sincepgjdbc/pgjdbc#3390 pgjdbc returns current catalogwhen calling `Connection.getCatalog`.
wendigo added a commit to trinodb/trino that referenced this pull requestMay 16, 2025
Sincepgjdbc/pgjdbc#3390 pgjdbc returns current catalogwhen calling `Connection.getCatalog`.
filiphr added a commit to filiphr/flowable-engine that referenced this pull requestMay 24, 2025
This aligns with other places in our production code where we only use the provided catalog value if it is not empty.There has been a change in Postgres in how it handles catalog with empty value.Seepgjdbc/pgjdbc#3390
benkard added a commit to benkard/mulkcms2 that referenced this pull requestJul 4, 2025
This MR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [flow-bin](https://github.com/flowtype/flow-bin) ([changelog](https://github.com/facebook/flow/blob/master/Changelog.md)) | devDependencies | minor | [`^0.247.0` -> `^0.274.0`](https://renovatebot.com/diffs/npm/flow-bin/0.247.1/0.274.2) || [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | build | patch | `42.7.4` -> `42.7.7` || [org.liquibase:liquibase-maven-plugin](http://www.liquibase.org/liquibase-maven-plugin) ([source](https://github.com/liquibase/liquibase)) | build | minor | `4.29.2` -> `4.32.0` || [org.jsoup:jsoup](https://jsoup.org/) ([source](https://github.com/jhy/jsoup)) | compile | minor | `1.18.1` -> `1.21.1` || [net.java.dev.jna:jna](https://github.com/java-native-access/jna) | compile | minor | `5.15.0` -> `5.17.0` || [io.hypersistence:hypersistence-utils-hibernate-70](https://github.com/vladmihalcea/hypersistence-utils) | compile | patch | `3.10.0` -> `3.10.1` || [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.43.0` -> `2.44.5` || [org.apache.maven.plugins:maven-enforcer-plugin](https://maven.apache.org/enforcer/) | build | minor | `3.5.0` -> `3.6.0` || [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.13.0` -> `3.14.0` |---### Release Notes<details><summary>flowtype/flow-bin</summary>### [`v0.274.2`](flow/flow-bin@33ba0ae...7a5fe2f)[Compare Source](flow/flow-bin@33ba0ae...7a5fe2f)### [`v0.274.1`](flow/flow-bin@2e4378a...33ba0ae)[Compare Source](flow/flow-bin@2e4378a...33ba0ae)### [`v0.274.0`](flow/flow-bin@c5226c9...2e4378a)[Compare Source](flow/flow-bin@c5226c9...2e4378a)### [`v0.273.1`](flow/flow-bin@b27a083...c5226c9)[Compare Source](flow/flow-bin@b27a083...c5226c9)### [`v0.272.2`](flow/flow-bin@bbfb18b...b27a083)[Compare Source](flow/flow-bin@bbfb18b...b27a083)### [`v0.272.1`](flow/flow-bin@0d366a0...bbfb18b)[Compare Source](flow/flow-bin@0d366a0...bbfb18b)### [`v0.272.0`](flow/flow-bin@d8aeeaf...0d366a0)[Compare Source](flow/flow-bin@d8aeeaf...0d366a0)### [`v0.271.0`](flow/flow-bin@4f66822...d8aeeaf)[Compare Source](flow/flow-bin@4f66822...d8aeeaf)### [`v0.270.0`](flow/flow-bin@c6688e6...4f66822)[Compare Source](flow/flow-bin@c6688e6...4f66822)### [`v0.269.1`](flow/flow-bin@64d5dff...c6688e6)[Compare Source](flow/flow-bin@64d5dff...c6688e6)### [`v0.268.0`](flow/flow-bin@e5dc5e2...64d5dff)[Compare Source](flow/flow-bin@e5dc5e2...64d5dff)### [`v0.267.0`](flow/flow-bin@708e9da...e5dc5e2)[Compare Source](flow/flow-bin@708e9da...e5dc5e2)### [`v0.266.1`](flow/flow-bin@a25570a...708e9da)[Compare Source](flow/flow-bin@a25570a...708e9da)### [`v0.266.0`](flow/flow-bin@9fe14be...a25570a)[Compare Source](flow/flow-bin@9fe14be...a25570a)### [`v0.265.3`](flow/flow-bin@e35201f...9fe14be)[Compare Source](flow/flow-bin@e35201f...9fe14be)### [`v0.265.2`](flow/flow-bin@3310f3b...e35201f)[Compare Source](flow/flow-bin@3310f3b...e35201f)### [`v0.265.1`](flow/flow-bin@3d9eb6b...3310f3b)[Compare Source](flow/flow-bin@3d9eb6b...3310f3b)### [`v0.265.0`](flow/flow-bin@c27e9f2...3d9eb6b)[Compare Source](flow/flow-bin@c27e9f2...3d9eb6b)### [`v0.264.0`](flow/flow-bin@fbd62c2...c27e9f2)[Compare Source](flow/flow-bin@fbd62c2...c27e9f2)### [`v0.263.0`](flow/flow-bin@6f390f3...fbd62c2)[Compare Source](flow/flow-bin@6f390f3...fbd62c2)### [`v0.262.0`](flow/flow-bin@7cdf16d...6f390f3)[Compare Source](flow/flow-bin@7cdf16d...6f390f3)### [`v0.261.2`](flow/flow-bin@299a032...7cdf16d)[Compare Source](flow/flow-bin@299a032...7cdf16d)### [`v0.261.1`](flow/flow-bin@5aafae9...299a032)[Compare Source](flow/flow-bin@5aafae9...299a032)### [`v0.261.0`](flow/flow-bin@b630c2e...5aafae9)[Compare Source](flow/flow-bin@b630c2e...5aafae9)### [`v0.260.0`](flow/flow-bin@3ad8609...b630c2e)[Compare Source](flow/flow-bin@3ad8609...b630c2e)### [`v0.259.1`](flow/flow-bin@518e655...3ad8609)[Compare Source](flow/flow-bin@518e655...3ad8609)### [`v0.259.0`](flow/flow-bin@6b44f16...518e655)[Compare Source](flow/flow-bin@6b44f16...518e655)### [`v0.258.1`](flow/flow-bin@f896a24...6b44f16)[Compare Source](flow/flow-bin@f896a24...6b44f16)### [`v0.258.0`](flow/flow-bin@d56a9db...f896a24)[Compare Source](flow/flow-bin@d56a9db...f896a24)### [`v0.257.1`](flow/flow-bin@3833ba2...d56a9db)[Compare Source](flow/flow-bin@3833ba2...d56a9db)### [`v0.257.0`](flow/flow-bin@9df2d7e...3833ba2)[Compare Source](flow/flow-bin@9df2d7e...3833ba2)### [`v0.256.0`](flow/flow-bin@b2ef58c...9df2d7e)[Compare Source](flow/flow-bin@b2ef58c...9df2d7e)### [`v0.255.0`](flow/flow-bin@e96e0c0...b2ef58c)[Compare Source](flow/flow-bin@e96e0c0...b2ef58c)### [`v0.254.2`](flow/flow-bin@5d4eb96...e96e0c0)[Compare Source](flow/flow-bin@5d4eb96...e96e0c0)### [`v0.254.1`](flow/flow-bin@386571a...5d4eb96)[Compare Source](flow/flow-bin@386571a...5d4eb96)### [`v0.254.0`](flow/flow-bin@2d1ed37...386571a)[Compare Source](flow/flow-bin@2d1ed37...386571a)### [`v0.253.0`](flow/flow-bin@8f3f2d6...2d1ed37)[Compare Source](flow/flow-bin@8f3f2d6...2d1ed37)### [`v0.252.0`](flow/flow-bin@f1169c6...8f3f2d6)[Compare Source](flow/flow-bin@f1169c6...8f3f2d6)### [`v0.251.1`](flow/flow-bin@c50c846...f1169c6)[Compare Source](flow/flow-bin@c50c846...f1169c6)### [`v0.251.0`](flow/flow-bin@41582c8...c50c846)[Compare Source](flow/flow-bin@41582c8...c50c846)### [`v0.250.0`](flow/flow-bin@030d7cf...41582c8)[Compare Source](flow/flow-bin@030d7cf...41582c8)### [`v0.249.0`](flow/flow-bin@7f53cc6...030d7cf)[Compare Source](flow/flow-bin@7f53cc6...030d7cf)### [`v0.248.1`](flow/flow-bin@e6851f8...7f53cc6)[Compare Source](flow/flow-bin@e6851f8...7f53cc6)### [`v0.248.0`](flow/flow-bin@70454fd...e6851f8)[Compare Source](flow/flow-bin@70454fd...e6851f8)</details><details><summary>pgjdbc/pgjdbc</summary>### [`v42.7.7`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#​4277-2025-06-10)##### Security- security: **Client Allows Fallback to Insecure Authentication Despite channelBinding=require configuration.** Fix `channel binding required` handling to reject non-SASL authentication Previously, when channel binding was set to "require", the driver would silently ignore this requirement for non-SASL authentication methods. This could lead to a false sense of security when channel binding was explicitly requested but not actually enforced. The fix ensures that when channel binding is set to "require", the driver will reject connections that use non-SASL authentication methods or when SASL authentication has not completed properly. See the [Security Advisory](GHSA-hq9p-pm7w-8p54) for more detail. Reported by [George MacKerron](https://github.com/jawj) The following [CVE-2025-49146](https://nvd.nist.gov/vuln/detail/CVE-2025-49146) has been issued##### Added- test: Added ChannelBindingRequiredTest to verify proper behavior of channel binding settings### [`v42.7.6`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#​4276)##### Features- fix: Enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property [MR #​3513](pgjdbc/pgjdbc#3513)##### Performance Improvements- performance: Improve ResultSetMetadata.fetchFieldMetaData by using IN row values instead of UNION ALL for improved query performance (later reverted) [MR #​3510](pgjdbc/pgjdbc#3510)- feat:Use a single simple query for all startup parameters, so groupStartupParameters is no longer needed [MR #​3613](pgjdbc/pgjdbc#3613)-### [`v42.7.5`](https://github.com/pgjdbc/pgjdbc/blob/HEAD/CHANGELOG.md#​4275-2025-01-14-080000--0400)##### Added- ci: Test with Java 23 [MR #​3381](pgjdbc/pgjdbc#3381)##### Fixed- regression: revert change in [`fc60537`](pgjdbc/pgjdbc@fc60537) [MR #​3476](pgjdbc/pgjdbc#3476)- fix: PgDatabaseMetaData implementation of catalog as param and return value [MR #​3390](pgjdbc/pgjdbc#3390)- fix: Support default GSS credentials in the Java Postgres client [MR #​3451](pgjdbc/pgjdbc#3451)- fix: return only the transactions accessible by the current_user in XAResource.recover [MR #​3450](pgjdbc/pgjdbc#3450)- feat: don't force send extra_float_digits for PostgreSQL >= 12 fix [Issue #​3432](pgjdbc/pgjdbc#3432) [MR #​3446](pgjdbc/pgjdbc#3446)- fix: exclude "include columns" from the list of primary keys [MR #​3434](pgjdbc/pgjdbc#3434)- perf: Enhance the meta query performance by specifying the oid. [MR #​3427](pgjdbc/pgjdbc#3427)- feat: support getObject(int, byte\[].class) for bytea [MR #​3274](pgjdbc/pgjdbc#3274)- docs: document infinity and some minor edits [MR #​3407](pgjdbc/pgjdbc#3407)- fix: Added way to check for major server version, fixed check for RULE [MR #​3402](pgjdbc/pgjdbc#3402)- docs: fixed remaining paragraphs [MR #​3398](pgjdbc/pgjdbc#3398)- docs: fixed paragraphs in javadoc comments [MR #​3397](pgjdbc/pgjdbc#3397)- fix: Reuse buffers and reduce allocations in GSSInputStream addresses [Issue #​3251](pgjdbc/pgjdbc#3251) [MR #​3255](pgjdbc/pgjdbc#3255)- chore: Update Gradle to 8.10.2 [MR #​3388](pgjdbc/pgjdbc#3388)- fix: getSchemas() [MR #​3386](pgjdbc/pgjdbc#3386)- fix: Update rpm postgresql-jdbc.spec.tpl with scram-client [MR #​3324](pgjdbc/pgjdbc#3324)- fix: Clearing thisRow and rowBuffer on close() of ResultSet [Issue #​3383](pgjdbc/pgjdbc#3383) [MR #​3384](pgjdbc/pgjdbc#3384)- fix: Package was renamed to maven-bundle-plugin [MR #​3382](pgjdbc/pgjdbc#3382)- fix: As of version 18 the RULE privilege has been removed [MR #​3378](pgjdbc/pgjdbc#3378)- fix: use buffered inputstream to create GSSInputStream [MR #​3373](pgjdbc/pgjdbc#3373)- test: get rid of 8.4, 9.0 pg versions and use >= jdk version 17 [MR #​3372](pgjdbc/pgjdbc#3372)- Changed docker-compose version and renamed script file in instructions to match the real file name [MR #​3363](pgjdbc/pgjdbc#3363)- test:Do not assume "test" database in DatabaseMetaDataTransactionIsolationTest [MR #​3364](pgjdbc/pgjdbc#3364)- try to categorize dependencies [MR #​3362](pgjdbc/pgjdbc#3362)</details><details><summary>liquibase/liquibase</summary>### [`v4.32.0`](https://github.com/liquibase/liquibase/blob/HEAD/changelog.txt#Liquibase-4320-is-a-major-release)[Compare Source](liquibase/liquibase@v4.31.1...v4.32.0)See the [Liquibase 4.32.0 Release Notes](https://docs.liquibase.com/start/release-notes/liquibase-release-notes/liquibase-4.32.0.html) for the complete set of release information.### [`v4.31.1`](https://github.com/liquibase/liquibase/blob/HEAD/changelog.txt#Liquibase-4311-is-a-patch-release)[Compare Source](liquibase/liquibase@v4.31.0...v4.31.1)> \[!IMPORTANT]> Liquibase 4.31.1 patches vulnerability found in Snowlake driver (CVE-2025-24789) and resolves issue with include and logicalfilepath reported in 4.31.0 (see 4.31.0 Release Notes)> \[!NOTE]> See the [Liquibase 4.31.1 Release Notes](https://docs.liquibase.com/start/release-notes/liquibase-release-notes/liquibase-4.31.1.html) for the complete set of release information.### [`v4.31.0`](https://github.com/liquibase/liquibase/blob/HEAD/changelog.txt#Liquibase-4310-is-a-major-release)[Compare Source](liquibase/liquibase@v4.30.0...v4.31.0)> \[!NOTE]> See the [Liquibase 4.31.0 Release Notes](https://docs.liquibase.com/start/release-notes/liquibase-release-notes/liquibase-4.31.0.html) for the complete set of release information.### [`v4.30.0`](https://github.com/liquibase/liquibase/blob/HEAD/changelog.txt#Liquibase-4300-is-a-major-release)[Compare Source](liquibase/liquibase@v4.29.2...v4.30.0)> \[!IMPORTANT]> Liquibase 4.30.0 contains new capabilities and notable enhancements for Liquibase OSS and Pro users including Anonymous Analytics and deprecation of the MacOS dmg installer.> \[!NOTE]> See the [Liquibase 4.30.0 Release Notes](https://docs.liquibase.com/start/release-notes/liquibase-release-notes/liquibase-4.30.0.html) for the complete set of release information.</details><details><summary>jhy/jsoup</summary>### [`v1.21.1`](https://github.com/jhy/jsoup/blob/HEAD/CHANGES.md#​1211-2025-Jun-23)##### Changes- Removed previously deprecated methods. [#​2317](jhy/jsoup#2317)- Deprecated the `:matchText` pseduo-selector due to its side effects on the DOM; use the new `::textnode` selector and the `Element#selectNodes(String css, Class type)` method instead. [#​2343](jhy/jsoup#2343)- Deprecated `Connection.Response#bufferUp()` in lieu of `Connection.Response#readFully()` which can throw a checked IOException.- Deprecated internal methods `Validate#ensureNotNull` (replaced by typed `Validate#expectNotNull`); protected HTML appenders from Attribute and Node.- If you happen to be using any of the deprecated methods, please take the opportunity now to migrate away from them, as they will be removed in a future release.##### Improvements- Enhanced the `Selector` to support direct matching against nodes such as comments and text nodes. For example, you can now find an element that follows a specific comment: `::comment:contains(prices) + p` will select `p` elements immediately after a `<!-- prices: -->` comment. Supported types include `::node`, `::leafnode`, `::comment`, `::text`, `::data`, and `::cdata`. Node contextual selectors like `::node:contains(text)`, `:matches(regex)`, and `:blank` are also supported. Introduced `Element#selectNodes(String css)` and `Element#selectNodes(String css, Class nodeType)` for direct node selection. [#​2324](jhy/jsoup#2324)- Added `TagSet#onNewTag(Consumer<Tag> customizer)`: register a callback that’s invoked for each new or cloned Tag when it’s inserted into the set. Enables dynamic tweaks of tag options (for example, marking all custom tags as self-closing, or everything in a given namespace as preserving whitespace).- Made `TokenQueue` and `CharacterReader` autocloseable, to ensure that they will release their buffers back to the buffer pool, for later reuse.- Added `Selector#evaluatorOf(String css)`, as a clearer way to obtain an Evaluator from a CSS query. An alias of `QueryParser.parse(String css)`.- Custom tags (defined via the `TagSet`) in a foreign namespace (e.g. SVG) can be configured to parse as data tags.- Added `NodeVisitor#traverse(Node)` to simplify node traversal calls (vs. importing `NodeTraversor`).- Updated the default user-agent string to improve compatibility. [#​2341](jhy/jsoup#2341)- The HTML parser now allows the specific text-data type (Data, RcData) to be customized for known tags. (Previously, that was only supported on custom tags.) [#​2326](jhy/jsoup#2326).- Added `Connection#readFully()` as a replacement for `Connection#bufferUp()` with an explicit IOException. Similarly, added `Connection#readBody()` over `Connection#body()`. Deprecated `Connection#bufferUp()`. [#​2327](jhy/jsoup#2327)- When serializing HTML, the `<` and `>` characters are now escaped in attributes. This helps prevent a class of mutation XSS attacks. [#​2337](jhy/jsoup#2337)- Changed `Connection` to prefer using the JDK's HttpClient over HttpUrlConnection, if available, to enable HTTP/2 support by default. Users can disable via `-Djsoup.useHttpClient=false`. [#​2340](jhy/jsoup#2340)##### Bug Fixes- The contents of a `script` in a `svg` foreign context should be parsed as script data, not text. [#​2320](jhy/jsoup#2320)- `Tag#isFormSubmittable()` was updating the Tag's options. [#​2323](jhy/jsoup#2323)- The HTML pretty-printer would incorrectly trim whitespace when text followed an inline element in a block element. [#​2325](jhy/jsoup#2325)- Custom tags with hyphens or other non-letter characters in their names now work correctly as Data or RcData tags. Their closing tags are now tokenized properly. [#​2332](jhy/jsoup#2332)- When cloning an Element, the clone would retain the source's cached child Element list (if any), which could lead to incorrect results when modifying the clone's child elements. [#​2334](jhy/jsoup#2334)### [`v1.20.1`](https://github.com/jhy/jsoup/blob/HEAD/CHANGES.md#​1201-2025-Apr-29)##### Changes- To better follow the HTML5 spec and current browsers, the HTML parser no longer allows self-closing tags (`<foo />`) to close HTML elements by default. Foreign content (SVG, MathML), and content parsed with the XML parser, still supports self-closing tags. If you need specific HTML tags to support self-closing, you can register a custom tag via the `TagSet` configured in `Parser.tagSet()`, using `Tag#set(Tag.SelfClose)`. Standard void tags (such as `<img>`, `<br>`, etc.) continue to behave as usual and are not affected by this change. [#​2300](jhy/jsoup#2300).- The following internal components have been **deprecated**. If you do happen to be using any of these, please take the opportunity now to migrate away from them, as they will be removed in jsoup 1.21.1. - `ChangeNotifyingArrayList`, `Document.updateMetaCharsetElement()`, `Document.updateMetaCharsetElement(boolean)`, `HtmlTreeBuilder.isContentForTagData(String)`, `Parser.isContentForTagData(String)`, `Parser.setTreeBuilder(TreeBuilder)`, `Tag.formatAsBlock()`, `Tag.isFormListed()`, `TokenQueue.addFirst(String)`, `TokenQueue.chompTo(String)`, `TokenQueue.chompToIgnoreCase(String)`, `TokenQueue.consumeToIgnoreCase(String)`, `TokenQueue.consumeWord()`, `TokenQueue.matchesAny(String...)`##### Functional Improvements- Rebuilt the HTML pretty-printer, to simplify and consolidate the implementation, improve consistency, support custom Tags, and provide a cleaner path for ongoing improvements. The specific HTML produced by the pretty-printer may be different from previous versions. [#​2286](jhy/jsoup#2286).- Added the ability to define custom tags, and to modify properties of known tags, via the `TagSet` tag collection. Their properties can impact both the parse and how content is serialized (output as HTML or XML). [#​2285](jhy/jsoup#2285).- `Element.cssSelector()` will prefer to return shorter selectors by using ancestor IDs when available and unique. E.g. `#id > div > p` instead of `html > body > div > div > p` [#​2283](jhy/jsoup#2283).- Added `Elements.deselect(int index)`, `Elements.deselect(Object o)`, and `Elements.deselectAll()` methods to remove elements from the `Elements` list without removing them from the underlying DOM. Also added `Elements.asList()` method to get a modifiable list of elements without affecting the DOM. (Individual Elements remain linked to the DOM.) [#​2100](jhy/jsoup#2100).- Added support for sending a request body from an InputStream with `Connection.requestBodyStream(InputStream stream)`. [#​1122](jhy/jsoup#1122).- The XML parser now supports scoped xmlns: prefix namespace declarations, and applies the correct namespace to Tags and Attributes. Also, added `Tag#prefix()`, `Tag#localName()`, `Attribute#prefix()`, `Attribute#localName()`, and `Attribute#namespace()` to retrieve these. [#​2299](jhy/jsoup#2299).- CSS identifiers are now escaped and unescaped correctly to the CSS spec. `Element#cssSelector()` will emit appropriately escaped selectors, and the QueryParser supports those. Added `Selector.escapeCssIdentifier()` and `Selector.unescapeCssIdentifier()`. [#​2297](jhy/jsoup#2297), [#​2305](jhy/jsoup#2305)##### Structure and Performance Improvements- Refactored the CSS `QueryParser` into a clearer recursive descent parser. [#​2310](jhy/jsoup#2310).- CSS selectors with consecutive combinators (e.g. `div >> p`) will throw an explicit parse exception. [#​2311](jhy/jsoup#2311).- Performance: reduced the shallow size of an Element from 40 to 32 bytes, and the NodeList from 32 to 24. [#​2307](jhy/jsoup#2307).- Performance: reduced GC load of new StringBuilders when tokenizing input HTML. [#​2304](jhy/jsoup#2304).- Made `Parser` instances threadsafe, so that inadvertent use of the same instance across threads will not lead to errors. For actual concurrency, use `Parser#newInstance()` per thread. [#​2314](jhy/jsoup#2314).##### Bug Fixes- Element names containing characters invalid in XML are now normalized to valid XML names when serializing. [#​1496](jhy/jsoup#1496).- When serializing to XML, characters that are invalid in XML 1.0 should be removed (not encoded). [#​1743](jhy/jsoup#1743).- When converting a `Document` to the W3C DOM in `W3CDom`, elements with an attribute in an undeclared namespace now get a declaration of `xmlns:prefix="undefined"`. This allows subsequent serialization to XML via `W3CDom.asString()` to succeed. [#​2087](jhy/jsoup#2087).- The `StreamParser` could emit the final elements of a document twice, due to how `onNodeCompleted` was fired when closing out the stack. [#​2295](jhy/jsoup#2295).- When parsing with the XML parser and error tracking enabled, the trailing `?` in `<?xml version="1.0"?>` would incorrectly emit an error. [#​2298](jhy/jsoup#2298).- Calling `Element#cssSelector()` on an element with combining characters in the class or ID now produces the correct output. [#​1984](jhy/jsoup#1984).### [`v1.19.1`](https://github.com/jhy/jsoup/blob/HEAD/CHANGES.md#​1191-2025-Mar-04)##### Changes- Added support for **http/2** requests in `Jsoup.connect()`, when running on Java 11+, via the Java HttpClient implementation. [#​2257](jhy/jsoup#2257). - In this version of jsoup, the default is to make requests via the HttpUrlConnection implementation: use **`System.setProperty("jsoup.useHttpClient", "true");`** to enable making requests via the HttpClient instead , which will enable http/2 support, if available. This will become the default in a later version of jsoup, so now is a good time to validate it. - If you are repackaging the jsoup jar in your deployment (i.e. creating a shaded- or a fat-jar), make sure to specify that as a Multi-Release JAR. - If the `HttpClient` impl is not available in your JRE, requests will continue to be made via `HttpURLConnection` (in `http/1.1` mode).- Updated the minimum Android API Level validation from 10 to **21**. As with previous jsoup versions, Android developers need to enable core library desugaring. The minimum Java version remains Java 8. [#​2173](jhy/jsoup#2173)- Removed previously deprecated class: `org.jsoup.UncheckedIOException` (replace with `java.io.UncheckedIOException`); moved previously deprecated method `Element Element#forEach(Consumer)` to `void Element#forEach(Consumer())`. [#​2246](jhy/jsoup#2246)- Deprecated the methods `Document#updateMetaCharsetElement(boolean)` and `Document#updateMetaCharsetElement()`, as the setting had no effect. When `Document#charset(Charset)` is called, the document's meta charset or XML encoding instruction is always set. [#​2247](jhy/jsoup#2247)##### Improvements- When cleaning HTML with a `Safelist` that preserves relative links, the `isValid()` method will now consider these links valid. Additionally, the enforced attribute `rel=nofollow` will only be added to external links when configured in the safelist. [#​2245](jhy/jsoup#2245)- Added `Element#selectStream(String query)` and `Element#selectStream(Evaluator)` methods, that return a `Stream` of matching elements. Elements are evaluated and returned as they are found, and the stream can be terminated early. [#​2092](jhy/jsoup#2092)- `Element` objects now implement `Iterable`, enabling them to be used in enhanced for loops.- Added support for fragment parsing from a `Reader` via `Parser#parseFragmentInput(Reader, Element, String)`. [#​1177](jhy/jsoup#1177)- Reintroduced CLI executable examples, in `jsoup-examples.jar`. [#​1702](jhy/jsoup#1702)- Optimized performance of selectors like `#id .class` (and other similar descendant queries) by around 4.6x, by better balancing the Ancestor evaluator's cost function in the query planner. [#​2254](jhy/jsoup#2254)- Removed the legacy parsing rules for `<isindex>` tags, which would autovivify a `form` element with labels. This is no longer in the spec.- Added `Elements.selectFirst(String cssQuery)` and `Elements.expectFirst(String cssQuery)`, to select the first matching element from an `Elements` list. [#​2263](jhy/jsoup#2263)- When parsing with the XML parser, XML Declarations and Processing Instructions are directly handled, vs bouncing through the HTML parser's bogus comment handler. Serialization for non-doctype declarations no longer end with a spurious `!`. [#​2275](jhy/jsoup#2275)- When converting parsed HTML to XML or the W3C DOM, element names containing `<` are normalized to `_` to ensure valid XML. For example, `<foo<bar>` becomes `<foo_bar>`, as XML does not allow `<` in element names, but HTML5 does. [#​2276](jhy/jsoup#2276)- Reimplemented the HTML5 Adoption Agency Algorithm to the current spec. This handles mis-nested formating / structural elements. [#​2278](jhy/jsoup#2278)##### Bug Fixes- If an element has an `;` in an attribute name, it could not be converted to a W3C DOM element, and so subsequent XPath queries could miss that element. Now, the attribute name is more completely normalized. [#​2244](jhy/jsoup#2244)- For backwards compatibility, reverted the internal attribute key for doctype names to "name". [#​2241](jhy/jsoup#2241)- In `Connection`, skip cookies that have no name, rather than throwing a validation exception. [#​2242](jhy/jsoup#2242)- When running on JDK 1.8, the error `java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;` could be thrown when calling `Response#body()` after parsing from a URL and the buffer size was exceeded. [#​2250](jhy/jsoup#2250)- For backwards compatibility, allow `null` InputStream inputs to `Jsoup.parse(InputStream stream, ...)`, by returning an empty `Document`. [#​2252](jhy/jsoup#2252)- A `template` tag containing an `li` within an open `li` would be parsed incorrectly, as it was not recognized as a "special" tag (which have additional processing rules). Also, added the SVG and MathML namespace tags to the list of special tags. [#​2258](jhy/jsoup#2258)- A `template` tag containing a `button` within an open `button` would be parsed incorrectly, as the "in button scope" check was not aware of the `template` element. Corrected other instances including MathML and SVG elements, also. [#​2271](jhy/jsoup#2271)- An `:nth-child` selector with a negative digit-less step, such as `:nth-child(-n+2)`, would be parsed incorrectly as a positive step, and so would not match as expected. [#​1147](jhy/jsoup#1147)- Calling `doc.charset(charset)` on an empty XML document would throw an `IndexOutOfBoundsException`. [#​2266](jhy/jsoup#2266)- Fixed a memory leak when reusing a nested `StructuralEvaluator` (e.g., a selector ancestor chain like `A B C`) by ensuring cache reset calls cascade to inner members. [#​2277](jhy/jsoup#2277)- Concurrent calls to `doc.clone().append(html)` were not supported. When a document was cloned, its `Parser` was not cloned but was a shallow copy of the original parser. [#​2281](jhy/jsoup#2281)### [`v1.18.3`](https://github.com/jhy/jsoup/blob/HEAD/CHANGES.md#​1183-2024-Dec-02)##### Bug Fixes- When serializing to XML, attribute names containing `-`, `.`, or digits were incorrectly marked as invalid and removed. [2235](jhy/jsoup#2235)### [`v1.18.2`](https://github.com/jhy/jsoup/blob/HEAD/CHANGES.md#​1182-2024-Nov-27)##### Improvements- Optimized the throughput and memory use throughout the input read and parse flows, with heap allocations and GC down between -6% and -89%, and throughput improved up to +143% for small inputs. Most inputs sizes will see throughput increases of ~ 20%. These performance improvements come through recycling the backing `byte[]` and `char[]` arrays used to read and parse the input. [2186](jhy/jsoup#2186)- Speed optimized `html()` and `Entities.escape()` when the input contains UTF characters in a supplementary plane, by around 49%. [2183](jhy/jsoup#2183)- The form associated elements returned by `FormElement.elements()` now reflect changes made to the DOM, subsequently to the original parse. [2140](jhy/jsoup#2140)- In the `TreeBuilder`, the `onNodeInserted()` and `onNodeClosed()` events are now also fired for the outermost / root `Document` node. This enables source position tracking on the Document node (which was previously unset). And it also enables the node traversor to see the outer Document node. [2182](jhy/jsoup#2182)- Selected Elements can now be position swapped inline using `Elements#set()`. [2212](jhy/jsoup#2212)##### Bug Fixes- `Element.cssSelector()` would fail if the element's class contained a `*` character. [2169](jhy/jsoup#2169)- When tracking source ranges, a text node following an invalid self-closing element may be left untracked. [2175](jhy/jsoup#2175)- When a document has no doctype, or a doctype not named `html`, it should be parsed in Quirks Mode. [2197](jhy/jsoup#2197)- With a selector like `div:has(span + a)`, the `has()` component was not working correctly, as the inner combining query caused the evaluator to match those against the outer's siblings, not children. [2187](jhy/jsoup#2187)- A selector query that included multiple `:has()` components in a nested `:has()` might incorrectly execute. [2131](jhy/jsoup#2131)- When cookie names in a response are duplicated, the simple view of cookies available via `Connection.Response#cookies()` will provide the last one set. Generally it is better to use the [Jsoup.newSession](https://jsoup.org/cookbook/web/request-session) method to maintain a cookie jar, as that applies appropriate path selection on cookies when making requests. [1831](jhy/jsoup#1831)- When parsing named HTML entities, base entities should resolve if they are a prefix of the input token (and not in an attribute). [2207](jhy/jsoup#2207)- Fixed incorrect tracking of source ranges for attributes merged from late-occurring elements that were implicitly created (`html` or `body`). [2204](jhy/jsoup#2204)- Follow the current HTML specification in the tokenizer to allow `<` as part of a tag name, instead of emitting it as a character node. [2230](jhy/jsoup#2230)- Similarly, allow a `<` as the start of an attribute name, vs creating a new element. The previous behavior was intended to parse closer to what we anticipated the author's intent to be, but that does not align to the spec or to how browsers behave. [1483](jhy/jsoup#1483)</details><details><summary>java-native-access/jna</summary>### [`v5.17.0`](https://github.com/java-native-access/jna/blob/HEAD/CHANGES.md#Release-5170)[Compare Source](java-native-access/jna@5.16.0...5.17.0)\================## Features- [#​1658](java-native-access/jna#1658): Add win32 power event constants, types, and functions - [@​eranl](https://github.com/eranl).## Bug Fixes- [#​1647](java-native-access/jna#1647): Fix calls to jnidispatch on Android with 16KB page size (part 2) - [@​BugsBeGone](https://github.com/BugsBeGone).### [`v5.16.0`](https://github.com/java-native-access/jna/blob/HEAD/CHANGES.md#Release-5160)[Compare Source](java-native-access/jna@5.15.0...5.16.0)\==============## Features- [#​1626](java-native-access/jna#1626): Add caching of field list and field validation in `Structure` along with more efficient reentrant read-write locking instead of synchronized() blocks - [@​BrettWooldridge](https://github.com/brettwooldridge)## Bug Fixes- [#​1618](java-native-access/jna#1618): Fix calls to jnidispatch on Android with 16KB page size - [@​Thomyrock](https://github.com/Thomyrock)</details><details><summary>vladmihalcea/hypersistence-utils</summary>### [`v3.10.1`](https://github.com/vladmihalcea/hypersistence-utils/blob/HEAD/changelog.txt#Version-3101---June-14-2025)\================================================================================Update description in pom.xml to mention support of Hibernate 6.6 [#​790](vladmihalcea/hypersistence-utils#790)Remove the central-publishing-maven-plugin dependency [#​789](vladmihalcea/hypersistence-utils#789)</details><details><summary>diffplug/spotless</summary>### [`v2.44.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#​2440---2024-01-15)##### Added- New static method to `DiffMessageFormatter` which allows to retrieve diffs with their line numbers ([#​1960](diffplug/spotless#1960))- Gradle - Support for formatting shell scripts via [shfmt](https://github.com/mvdan/sh). ([#​1994](diffplug/spotless#1994))##### Fixed- Fix empty files with biome >= 1.5.0 when formatting files that are in the ignore list of the biome configuration file. ([#​1989](diffplug/spotless#1989) fixes [#​1987](diffplug/spotless#1987))- Fix a regression in BufStep where the same arguments were being provided to every `buf` invocation. ([#​1976](diffplug/spotless#1976))##### Changed- Use palantir-java-format 2.39.0 on Java 21. ([#​1948](diffplug/spotless#1948))- Bump default `ktlint` version to latest `1.0.1` -> `1.1.1`. ([#​1973](diffplug/spotless#1973))- Bump default `googleJavaFormat` version to latest `1.18.1` -> `1.19.2`. ([#​1971](diffplug/spotless#1971))- Bump default `diktat` version to latest `1.2.5` -> `2.0.0`. ([#​1972](diffplug/spotless#1972))</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box---This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#3389 "Metadata results from getSchemas(String catalog, String schemaPattern) violate JDBC spec"
Fixes#3394 "getSchemas with empty string for schemaPattern returns schemas, violating JDBC spec"
All Submissions:
Changes to Existing Features: