Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork62
Description
Hi! First of all, thanks for a wonderful action. We do use it a lot.
We hit an issue where users who have write access to the repository can't trigger slash commands whenpermission property is set towrite. After investigation, I found out that the issue occurs if user has permissions on repository through the nested team (so the teammain is assignedwrite permissions on the repo, it has sub-teamsub, and user is a member of teamsub). I tried to reproduce the calls that actions does locally (specifically
| asyncgetActorPermission(repo:Repository,actor:string):Promise<string>{ |
the collaborators relation only returns first-level users (users that are directly added to repository) or members of the team that is added to the repository, but not nested teams
and this is something that could change in the future, but not right now.
I do understand that this is something relatively specific to our use case, but I am adding this in case someone hits the same problem and does not waste as much time as we did. I also checkedREST API version of this request, and it returns the correct list of collaborators. This could server as a substitute for current implementation, but would require getting all of the collaborators and then filtering by current actor name, which is not quite neat as the GraphQL version. So it is up to mainteners to make the call, but at least this could be added to README somewhere to save others some time.