- Notifications
You must be signed in to change notification settings - Fork106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove -n option from pecl.bat for shared extensions#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
As described inf94454a> When PHP is using shared extensions:>> ./configure --with-openssl=shared --enable-xml=shared>> The -n option in PHP command line (in the PECL shell script) removes them> from being enabled and PECL script won't work ok anymore. This goes mainly> for the xml and openssl PHP extensions which are needed to install PECL> extensions via the https protocol and to parse XML files.Unfortunately, the fix was only applied to pecl.sh, so the issuedescribed inhttps://bugs.php.net/bug.php?id=77522 still occurs onWindows when built with shared extensions.Apply the same fix to pecl.bat to avoid the issue on Windows.Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Kudos, SonarCloud Quality Gate passed!
|
ashnazg approved these changesNov 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described inf94454a
Unfortunately, the fix was only applied to
pecl.sh, so the issue described inhttps://bugs.php.net/bug.php?id=77522 still occurs on Windows when built with shared extensions.This PR applies the same fix to
pecl.batto avoid the issue on Windows.