- Notifications
You must be signed in to change notification settings - Fork106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unneeded code#108
Conversation
The reason the 2nd PR was created is because no release containing the original fix was ever tagger, and the 2nd PR author didn't look to see if there was an unreleased fix already in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does it hurt anything by keeping this as a last ditch safety check that$cacheid is indeed an array after thegetCacheId() call?
Probably not, but it does change the program flow: it returns earlier to the caller with false, skipping a couple of lines that were executed before these patches became necessary. This may sound a bit academic, but regression testing is a lot easier if you don't have to consider this. A patch should not change the program flow if not absolutely necessary. |
Included in v1.10.11 release. |
As pointed out by@arjendekorte,#106 should never have been merged, since#102 already provided a better fix.