Commita23b192

authored

feat: Log more debug info when failing to set duplicate value for field with unique values (#9919)

1 parent98a42e5 commita23b192Copy full SHA for a23b192

File tree

-1

lines changed

-1

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3842,6 +3842,7 @@ describe('schemas', () => {`
`3842`	`3842`	`});`
`3843`	`3843`
`3844`	`3844`	`it_id('cbd5d897-b938-43a4-8f5a-5d02dd2be9be')(it_exclude_dbs(['postgres']))('cannot update to duplicate value on unique index',done=>{`
	`3845`	`+loggerErrorSpy.calls.reset();`
`3845`	`3846`	`constindex={`
`3846`	`3847`	`code:1,`
`3847`	`3848`	`};`
`@@ -3868,6 +3869,12 @@ describe('schemas', () => {`
`3868`	`3869`	`.then(done.fail)`
`3869`	`3870`	`.catch(error=>{`
`3870`	`3871`	`expect(error.code).toEqual(Parse.Error.DUPLICATE_VALUE);`
	`3872`	`+// Client should only see generic message (no schema info exposed)`
	`3873`	`+expect(error.message).toEqual('A duplicate value for a field with unique values was provided');`
	`3874`	`+// Server logs should contain full MongoDB error message with detailed information`
	`3875`	`+expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:',jasmine.stringContaining('E11000 duplicate key error'));`
	`3876`	`+expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:',jasmine.stringContaining('test_UniqueIndexClass'));`
	`3877`	`+expect(loggerErrorSpy).toHaveBeenCalledWith('Duplicate key error:',jasmine.stringContaining('code_1'));`
`3871`	`3878`	`done();`
`3872`	`3879`	`});`
`3873`	`3880`	`});`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -519,7 +519,7 @@ export class MongoStorageAdapter implements StorageAdapter {`
`519`	`519`	`.then(()=>({ops:[mongoObject]}))`
`520`	`520`	`.catch(error=>{`
`521`	`521`	`if(error.code===11000){`
`522`		`-//Duplicatevalue`
	`522`	`+logger.error('Duplicatekey error:',error.message);`
`523`	`523`	`consterr=newParse.Error(`
`524`	`524`	`Parse.Error.DUPLICATE_VALUE,`
`525`	`525`	`'A duplicate value for a field with unique values was provided'`
`@@ -605,6 +605,7 @@ export class MongoStorageAdapter implements StorageAdapter {`
`605`	`605`	`.then(result=>mongoObjectToParseObject(className,result,schema))`
`606`	`606`	`.catch(error=>{`
`607`	`607`	`if(error.code===11000){`
	`608`	`+logger.error('Duplicate key error:',error.message);`
`608`	`609`	`thrownewParse.Error(`
`609`	`610`	`Parse.Error.DUPLICATE_VALUE,`
`610`	`611`	`'A duplicate value for a field with unique values was provided'`

Comments

(0)