Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Info panel covers whole sidebar if fewer objects than panels in multi-panel scenario#3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@mtrezza
Copy link
Member

@mtrezzamtrezza commentedDec 4, 2025•
edited by coderabbitaibot
Loading

Summary by CodeRabbit

  • Improvements
    • Panel toggle buttons now correctly display the count of panels (e.g., "Hide 2 Panels" vs. "Hide Panel").
    • Panel width is now properly calculated and displayed when panels are hidden.
    • Empty panel states now display aggregation data instead of blank space.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitaibot commentedDec 4, 2025•
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates panel toggle button labels to dynamically pluralize based on panel count. Introduces effectivePanelWidth calculation in DataBrowser to account for hidden panels, persists width adjustments to localStorage, and modifies panel rendering logic to display aggregation panels when no panels are currently shown.

Changes

Cohort / File(s)Change Summary
Toolbar label pluralization
src/components/Toolbar/Toolbar.react.js		Dynamically pluralizes panel toggle button labels: "Hide Panel" becomes "Hide {panelCount} Panels" and "Show Panel" becomes "Show {panelCount} Panels" when panelCount > 1.
DataBrowser panel width and rendering
src/dashboard/Data/Browser/DataBrowser.react.js		Introduces effectivePanelWidth calculation to adjust rendered width based on hidden panels; translates effective width back to full panel width on resize and persists to localStorage. Updates all UI components (BrowserTable, ResizableBox, per-panel rendering) to use effectivePanelWidth. Renders single AggregationPanel when no panels displayed, pulling data from cached multiPanelData or AggregationPanelData; adjusts isLoadingCloudFunction and selectedObjectId propagation accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • DataBrowser.react.js: Multiple interrelated logic changes affecting width calculations, state propagation, and render paths require careful verification of edge cases (hidden panels, no panels displayed, resize behavior) and localStorage persistence.
  • Toolbar.react.js: Label pluralization logic is straightforward but should be verified for correct panelCount handling across all toggle states.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between6aadff6 and004e764.

📒 Files selected for processing (2)
  • src/components/Toolbar/Toolbar.react.js (1 hunks)
  • src/dashboard/Data/Browser/DataBrowser.react.js (5 hunks)

Thanks for usingCodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

✅Snyk checks have passed. No issues have been found so far.

StatusScanner Critical High Medium LowTotal (0)
✅Open Source Security0000 0 issues

💻 Catch issues earlier using the plugins forVS Code,JetBrains IDEs,Visual Studio, andEclipse.

@mtrezzamtrezza merged commitdd3ba8d intoparse-community:alphaDec 4, 2025
11 of 12 checks passed
@mtrezzamtrezza deleted the fix/reisze-panel-width branchDecember 4, 2025 00:08
parseplatformorg pushed a commit that referenced this pull requestDec 4, 2025
# [8.2.0-alpha.2](8.2.0-alpha.1...8.2.0-alpha.2) (2025-12-04)### Bug Fixes* Info panel covers whole sidebar if fewer objects than panels in multi-panel scenario ([#3042](#3042)) ([dd3ba8d](dd3ba8d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version8.2.0-alpha.2

@parseplatformorgparseplatformorg added the state:released-alphaReleased as alpha version labelDec 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state:released-alphaReleased as alpha version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtrezza@parseplatformorg
[8]ページ先頭
©2009-2025 Movatter.jp