Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Update sockets#236

Merged
cbaker6 merged 20 commits intoparse-community:masterfromcbaker6:sockets
Nov 17, 2020
Merged

Update sockets#236

cbaker6 merged 20 commits intoparse-community:masterfromcbaker6:sockets
Nov 17, 2020

Conversation

@cbaker6
Copy link
Contributor

@cbaker6cbaker6 commentedNov 15, 2020•
edited
Loading

This should be merged after#235

Should this be 2.8.0? The starscream dependency had a major API change. The updates here weren't too difficult, but will need to see what happens on actual systems. I tested in one of my apps that uses simple liveQueries and works with no issues

@cbaker6cbaker6 marked this pull request as draftNovember 15, 2020 19:48
@cbaker6cbaker6 marked this pull request as ready for reviewNovember 15, 2020 21:26
@cbaker6cbaker6 requested review froma team anddrdazNovember 15, 2020 22:51
Copy link
Member

@drdazdrdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

cbaker6 reacted with thumbs up emoji
@cbaker6
Copy link
ContributorAuthor

@TomWFox and@drdaz do you agree that this one should be 2.8.0 and the previous PR 2.7.3?

Technically, I can combine them both for 2.8.0, but since this PR has a bigger dependency change, 2.7.3 would give users the option of having the new features with the old socket dependency

@drdaz
Copy link
Member

Splitting the changes into two releases would be exceptionally polite to our consumers actually. I like it.

@TomWFox
Copy link
Contributor

Sounds good to me.

TomWFox
TomWFox previously requested changesNov 16, 2020
Copy link
Contributor

@TomWFoxTomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The version the podspec needs updating too.

cbaker6 reacted with thumbs up emoji
cbaker6and others added8 commitsNovember 16, 2020 13:41
@cbaker6cbaker6 merged commit9619104 intoparse-community:masterNov 17, 2020
@cbaker6cbaker6 deleted the sockets branchNovember 17, 2020 00:01
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

2 more reviewers

@drdazdrdazdrdaz approved these changes

@TomWFoxTomWFoxTomWFox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please update Starscream dependency up to '~> 3.1.1' how it was before in yourv2.7.0 release.

3 participants

@cbaker6@drdaz@TomWFox
[8]ページ先頭
©2009-2025 Movatter.jp