Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added support for terminating a spawned worker if a timeout is reached#207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mathiasrw merged 2 commits intoparallel-js:masterfromamit777:master
Oct 6, 2020

Conversation

amit777
Copy link
Contributor

Hi, I found this lib because I was searching for a way to easily spawn a worker, but also be able to terminate it if a timeout is reached. The use case is that I want to time limit execution for certain operations.

I don't have any experience with the test frameworks in this lib, but if my pull request looks promising, I'm happy to learn and create a test spec. But only if you think this extra feature even belongs in parallel.js?

@amit777amit777 mentioned this pull requestOct 1, 2020
Copy link
Member

@mathiasrwmathiasrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Epic. Please also add a description of the new option in the readme file too.

@amit777
Copy link
ContributorAuthor

Thanks! I've added an update to the documentation. However, is it possible that the new timeout option will overwrite an environment variable that could be set in the Parallel constructor?

@mathiasrw
Copy link
Member

Thank you!

@mathiasrwmathiasrw merged commit1dedd68 intoparallel-js:masterOct 6, 2020
@mathiasrw
Copy link
Member

released as part of v1.1.0

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mathiasrwmathiasrwmathiasrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@amit777@mathiasrw

[8]ページ先頭

©2009-2025 Movatter.jp