- Notifications
You must be signed in to change notification settings - Fork113
Add webapp functionality and refactor papis add/update#457
Open
alejandrogallo wants to merge 2 commits intopapis:mainfrom
Open
Add webapp functionality and refactor papis add/update#457alejandrogallo wants to merge 2 commits intopapis:mainfrom
alejandrogallo wants to merge 2 commits intopapis:mainfrom
Conversation
add in GET and POST, and start refactoring papis-add in smart_i…Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d0f16dc to9a7d02cCompareUh oh!
There was an error while loading.Please reload this page.
| logger.info("handling doi '%s'", doi) | ||
| importers.append(papis.crossref.Importer.match(doi)) | ||
| if url: | ||
| logger.info("handling url '%s'", url) |
Check failure
Code scanning / CodeQL
Log Injection
This log entry depends on a [user-provided value](1).This log entry depends on a [user-provided value](1).
| importers.extend([papis.crossref.DoiFromPdfImporter.match(_file) | ||
| for _file in files]) | ||
| if doi: | ||
| logger.info("handling doi '%s'", doi) |
Check failure
Code scanning / CodeQL
Log Injection
This log entry depends on a [user-provided value](1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
There is a concept implementation of adding a document on the webapp
My idea of a workflow would be, the user inputs these inputs (maybe all of them)
and then the importers work in function
self.add_documentinserve.py.Then maybe create a temporary document and serve this document with the document view,
using a modified vwerion of the function
where maybe there is a flag that controls that this document is a preliminary temporary document
and the user gets a button to add this document to the database.
I think this kind of workflow would be common in most plugins that intend to add a document.
This case here is a good test in order to see what belongs to
cliand to therunfunktionin
papis.commands.addandpapis.commands.updatetoo.Incidentally, if we really make it to code a reasonable add functionality,
then the webapp would be pretty much usable for a lot of users, and I could present it
alongside the cli in fosdem, so this is quite important for papis IMO to get right.
This is also a chance to work again on the decisions that were made for adding papers,
which I think everyone feels it's well, kind of awkward right now (understandably so).
Related to#367 and other issues.
I'd like to pack most smart importer stuff in
smart_importer.pyfor now, I think this issensible.