Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add webapp functionality and refactor papis add/update#457

Open
alejandrogallo wants to merge 2 commits intopapis:mainfrom
alejandrogallo:feature/webapp-add
Open

Add webapp functionality and refactor papis add/update#457
alejandrogallo wants to merge 2 commits intopapis:mainfrom
alejandrogallo:feature/webapp-add

Conversation

@alejandrogallo
Copy link
Member

@alejandrogalloalejandrogallo commentedDec 22, 2022
edited
Loading

There is a concept implementation of adding a document on the webapp

image

My idea of a workflow would be, the user inputs these inputs (maybe all of them)
and then the importers work in functionself.add_document inserve.py.

Then maybe create a temporary document and serve this document with the document view,
using a modified vwerion of the function

        page = papis.web.docview.html(libname=libname, doc=doc)

where maybe there is a flag that controls that this document is a preliminary temporary document
and the user gets a button to add this document to the database.

I think this kind of workflow would be common in most plugins that intend to add a document.
This case here is a good test in order to see what belongs tocli and to therun funktion
inpapis.commands.add andpapis.commands.update too.

Incidentally, if we really make it to code a reasonable add functionality,
then the webapp would be pretty much usable for a lot of users, and I could present it
alongside the cli in fosdem, so this is quite important for papis IMO to get right.

This is also a chance to work again on the decisions that were made for adding papers,
which I think everyone feels it's well, kind of awkward right now (understandably so).
Related to#367 and other issues.

I'd like to pack most smart importer stuff insmart_importer.py for now, I think this is
sensible.

@alejandrogalloalejandrogallo changed the titleAddadd in GET and POST, and start refactoring papis-add in smart_i…Add webapp functionality and refactor papis add/updateDec 22, 2022
logger.info("handling doi '%s'", doi)
importers.append(papis.crossref.Importer.match(doi))
if url:
logger.info("handling url '%s'", url)

Check failure

Code scanning / CodeQL

Log Injection

This log entry depends on a [user-provided value](1).This log entry depends on a [user-provided value](1).
importers.extend([papis.crossref.DoiFromPdfImporter.match(_file)
for _file in files])
if doi:
logger.info("handling doi '%s'", doi)

Check failure

Code scanning / CodeQL

Log Injection

This log entry depends on a [user-provided value](1).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alejandrogallo

Comments


[8]ページ先頭

©2009-2026 Movatter.jp