Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature: Upgrade underlying Docker image to Trixie#10562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
stumpylog wants to merge1 commit intodev
base:dev
Choose a base branch
Loading
fromfeature-trixie-upgrade

Conversation

stumpylog
Copy link
Member

Proposed change

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality.Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with thecontributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, forbackend and / orfront-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, seedocumentation.
  • I have run allpre-commit hooks, seedocumentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylogstumpylog added the notableFlag PRs to highlight in releases labelAug 11, 2025
@github-actionsgithub-actionsbot added enhancementNew feature or enhancement non-trivialRequires approval by several team members labelsAug 11, 2025
@stumpylog
Copy link
MemberAuthor

Waiting fordocker-library/python#1042 andnodejs/docker-node#2253 to really be able to test this out and get a sense of the updated system packages.

@shamoonshamoon added this to theNext Release milestoneAug 11, 2025
@codecovCodecov
Copy link

codecovbot commentedAug 12, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.82%. Comparing base (495159f) to head (4634537).

Additional details and impacted files
@@           Coverage Diff           @@##              dev   #10562   +/-   ##=======================================  Coverage   97.82%   97.82%           =======================================  Files         524      524             Lines       23205    23205             Branches     1832     1888   +56     =======================================  Hits        22701    22701             Misses        504      504
ComponentsCoverage Δ
backend96.65% <ø> (ø)
frontend99.18% <ø> (ø)
FlagCoverage Δ
backend-python-3.1096.65% <ø> (ø)
backend-python-3.1196.65% <ø> (ø)
backend-python-3.1296.65% <ø> (ø)
frontend-node-20.x99.18% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

@stumpylog
Copy link
MemberAuthor

Incidentally should close#10426 just because

@shamoon
Copy link
Member

shamoon commentedAug 14, 2025
edited
Loading

I thoughtastral-sh/uv#15269 was the last piece of the puzzle, but still not. Is the issue somehow the inclusion of the uv version i.e.ERROR: failed to build: failed to solve: ghcr.io/astral-sh/uv:0.8.8-python3.12-trixie-slim: not found as opposed toghcr.io/astral-sh/uv:python3.12-trixie-slim?

Edit: Ah, maybe uv need to publish a release for those to get built

@stumpylog
Copy link
MemberAuthor

There's at least a rebuild for jbog2enc as well. I'll work on it more today

@stumpylog
Copy link
MemberAuthor

Hmmm, that's not a good build time. Just from a glance, it seems the nltk download is suddenly taking a ton of time on ARM64. I don't think we should block a release on this. It's probably going to be complicated finding out why

@shamoon
Copy link
Member

Oh wow yea that’s long! I had just assumed it wasn’t gonna finish when I saw. Yea I could see that being tricky to track down

@stumpylog
Copy link
MemberAuthor

It's trivial to reproduce:https://github.com/stumpylog/nltk-download-reproducer

I'll probably start with the Python image and see if the experts there can provide thoughts

@shamoonshamoon removed this from theNext Release milestoneAug 16, 2025
@stumpylog
Copy link
MemberAuthor

stumpylog commentedAug 18, 2025
edited
Loading

Tracking comment of issues, discussions, etc so I can find them again:

@shamoon
Copy link
Member

1h 8m 22s

Yea I guess so much for caching making a difference, bummer! Thanks for trying to get things moving, fingers crossed...

@shamoonshamoon added this to thev3.0.0 milestoneOct 1, 2025
@sonarqubecloudSonarQubeCloud
Copy link

@shamoon
Copy link
Member

Do we need to fix the 'detect duplicate' thing which is preventing the docker build here? Gives me a bit of a headache just thinking about that...

@stumpylog
Copy link
MemberAuthor

I think it can wait till the reorganizing of the workflows

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancementNew feature or enhancementnon-trivialRequires approval by several team membersnotableFlag PRs to highlight in releases

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stumpylog@shamoon

[8]ページ先頭

©2009-2025 Movatter.jp