Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2k
Feature: Upgrade underlying Docker image to Trixie#10562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Conversation
Waiting fordocker-library/python#1042 andnodejs/docker-node#2253 to really be able to test this out and get a sense of the updated system packages. |
f392a58
to1f8c60a
Comparecodecovbot commentedAug 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## dev #10562 +/- ##======================================= Coverage 97.82% 97.82% ======================================= Files 524 524 Lines 23205 23205 Branches 1832 1888 +56 ======================================= Hits 22701 22701 Misses 504 504
Flags with carried forward coverage won't be shown.Click here to find out more. |
Incidentally should close#10426 just because |
shamoon commentedAug 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I thoughtastral-sh/uv#15269 was the last piece of the puzzle, but still not. Is the issue somehow the inclusion of the uv version i.e. Edit: Ah, maybe uv need to publish a release for those to get built |
There's at least a rebuild for jbog2enc as well. I'll work on it more today |
1f8c60a
tofd0bec4
CompareHmmm, that's not a good build time. Just from a glance, it seems the nltk download is suddenly taking a ton of time on ARM64. I don't think we should block a release on this. It's probably going to be complicated finding out why |
Oh wow yea that’s long! I had just assumed it wasn’t gonna finish when I saw. Yea I could see that being tricky to track down |
It's trivial to reproduce:https://github.com/stumpylog/nltk-download-reproducer I'll probably start with the Python image and see if the experts there can provide thoughts |
1a933cc
to5bac39b
Comparestumpylog commentedAug 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Tracking comment of issues, discussions, etc so I can find them again:
|
Yea I guess so much for caching making a difference, bummer! Thanks for trying to get things moving, fingers crossed... |
5bac39b
to98accc4
Compare4e04bdc
toafdb5d8
Compareafdb5d8
to4634537
CompareDo we need to fix the 'detect duplicate' thing which is preventing the docker build here? Gives me a bit of a headache just thinking about that... |
I think it can wait till the reorganizing of the workflows |
Proposed change
Closes #(issue or discussion)
Type of change
Checklist:
pre-commit
hooks, seedocumentation.