Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
BUG: Raise TypeError when joining with non-DataFrame using 'on=' (GH#61434)#61454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
78fbc2c tob604714CompareAll checks passed except the Pyodide build, which failed due to a rate-limit (HTTP 429). The failure seems unrelated to this PR. A rerun should resolve it |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
b604714 to71eb2e7Compare| if isinstance(other, Iterable) and not isinstance( | ||
| other, (DataFrame, Series, str, bytes, bytearray) | ||
| ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ifisinstance(other,Iterable)andnotisinstance( | |
| other, (DataFrame,Series,str,bytes,bytearray) | |
| ): | |
| ifis_list_like(other): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also, this probably should be done inmerge
rhshadrachMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mroeschke - is_list_like will return True on a DataFrame. We only want to enter this block on a potential sequence of DataFrame/Series.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah OK ignore my suggestion then. But I believe this check should still be done inmerge probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah OK ignore my suggestion then. But I believe this check should still be done in
mergeprobably
ValueError is raised injoin() before the call reachesmerge whenon is specified. Would you prefer that I let these inputs flow intomerge and move the check there for consistency?
Uh oh!
There was an error while loading.Please reload this page.
71eb2e7 to6789fb6Compare6789fb6 toc9ac591Compare
Uh oh!
There was an error while loading.Please reload this page.
Closes GH#61434
What does this PR change?
When using
DataFrame.join()with theonparameter, passing an invalid object like adict,int, or third-party DataFrame previously resulted in unclear internal errors.This PR adds a minimal type check that raises a clear
TypeErrorwhenotheris not aDataFrame,Series, or a list of such objects. Valid list-based joins withoutonremain unaffected.Checklist
pre-commit run --all-filesdoc/source/whatsnew/v3.0.0.rst