NotificationsYou must be signed in to change notification settings
Fork18.5k
Star45.5k

BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute (#61443)#61451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mroeschke merged 3 commits intopandas-dev:mainfromiabhi4:fix-61443-df-constructor

May 19, 2025

Merged

BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute (#61443)#61451

mroeschke merged 3 commits intopandas-dev:mainfromiabhi4:fix-61443-df-constructor

May 19, 2025

Conversation

Copy link

Contributor

iabhi4 commentedMay 17, 2025•
edited
Loading

BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute

Previously, any object with a.name attribute (like somevtkArray-like objects) was assumed to be aSeries orIndex, causing the DataFrame constructor to misinterpret the input and raise errors when passed valid 2D array-likes.

This fix ensures we only apply the named-Series/Index logic when the input isactually an instance ofABCSeries orABCIndex, and thename is notNone.

A new test was added to ensure array-like subclasses with.name are handled correctly.

ClosesBUG:DataFrame constructor not compatible with array-like classes that have a'name' attribute #61443
Tests added and passing
Code passes all checks viapre-commit
Behavior verified with array-like +.name case
Entry added indoc/source/whatsnew/v3.0.0.rst

iabhi4 added2 commits

May 17, 2025 15:24

BUG: Fix DataFrame constructor misclassification of array-like with '…

09d4a63

…name' attributePreviously, any object with a .name attribute (like some vtkArray-like objects) was assumed to be a Series or Index, causing the constructor to misinterpret the input.This fix ensures we only apply the named-Index/Series logic when the input is actually an instance of ABCSeries or ABCIndex *and* has a non-None name.Closespandas-dev#61443.

Apply pre-commit fixes: isort and remove unused type ignore

9687457

Copy link

ContributorAuthor

iabhi4 commentedMay 18, 2025

Note: One unrelated pre-commit check failed:

Check for strings with misplaced spaces.................................................................Failed- hook id: unwanted-patterns-strings-with-misplaced-whitespacepandas/_libs/tslibs/offsets.pyx:5112: String has a space at the beginning instead of the end of the previous string.pandas/_libs/tslibs/offsets.pyx:5126: String has a space at the beginning instead of the end of the previous string.

One of the flagged lines includes:

f" instead.",

This has a space at thestart of the string rather than the end of the previous one, which violates theunwanted-patterns-strings-with-misplaced-whitespace pre-commit rule.

Since this file wasn't touched in this PR and is unrelated to the fix, I’ve left it as-is. Let me know if you'd like me to patch it.