Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: clean up wheel build workarounds now that Cython 3.1.0 is out#61446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mroeschke merged 1 commit intopandas-dev:mainfromrgommers:nogil-wheels-cleanup
May 16, 2025

Conversation

rgommers
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • Allcode checks passed.
  • Addedtype annotations to new arguments/methods/functions.
  • Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This simplifiers wheel builds for free-threaded CPython, which is useful in itself and I thought was a good idea before backporting the Windows cp313t wheel support to the 2.3.x branch, as just discussed at#61249 (comment).

This should have no changes in behavior, and mostly reverts the workarounds for unreleased Cython added initially ingh-60146. Other notes:

  • Changes thefree-threaded-support cibuildwheel setting toenable, because the former is now deprecated.
  • This leaves the license concatenation behavior unchanged. Note that it's skipped on Windows, and happens on other platforms. This was added without any discussion inCI: Add Windows wheels for the free-threaded build #60146. It looks inconsistent, but the bash invocation doesn't work on Windows so I'd like to leave it unchanged in this PR. A useful follow-up PR may be to remove the ad-hoc concatenation in favor of starting to usePEP 639.

I ran the wheel builds on my fork before opening this PR, they're passing (CI logs).

@lithomas1lithomas1 added the BuildLibrary building on various platforms labelMay 16, 2025
Copy link
Member

@lithomas1lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks Ralf!

@lithomas1lithomas1 added this to the2.3 milestoneMay 16, 2025
@mroeschkemroeschke merged commit17f0dd6 intopandas-dev:mainMay 16, 2025
99 of 100 checks passed
@mroeschke
Copy link
Member

Thanks@rgommers

@lumberbot-appLumberbot (App)
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 17f0dd6233a881702b36a301f4b8dd82f7d9f9a8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61446: CI: clean up wheel build workarounds now that Cython 3.1.0 is out'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61446-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR#61446 on branch 2.3.x (CI: clean up wheel build workarounds now that Cython 3.1.0 is out)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@rgommersrgommers deleted the nogil-wheels-cleanup branchMay 18, 2025 14:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mroeschkemroeschkemroeschke approved these changes

@lithomas1lithomas1lithomas1 approved these changes

Assignees
No one assigned
Labels
BuildLibrary building on various platformsStill Needs Manual Backport
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

3 participants
@rgommers@mroeschke@lithomas1
[8]ページ先頭
©2009-2025 Movatter.jp