Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
BLD: allow to build with non-MSVC compilers on Windows#61404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Always passing --vsenv to meson means pandas can't be built with gcc/clangon Windows.Instead add it to the cibuildwheel config so MSVC is still forced in CIwhen building wheels, and in various places where it is built via pip.
I understand that this is an edge case on Windows, and that mingw is not officially supported, but numpy/scipy also don't force msvc, so I though it's worth a try proposing this. Feedback welcome. |
Thanks for the PR. This makes sense, although I think the challenge is more comprehensively how we document the process for users that want to build on Windows. I have pretty limited Windows knowledge, but AFAIU we only document currently for the MSVC approach? So if we want to go this route, I think just need to make it clearer to contributors how they can opt in or out of the the different toolchains on Windows |
Uh oh!
There was an error while loading.Please reload this page.
Always passing --vsenv to meson means pandas can't be built with gcc/clang
on Windows.
Instead add it to the cibuildwheel config so MSVC is still forced in CI
when building wheels, and in various places where it is built via pip.