/preview

Website preview of this PR available at:https://pandas.pydata.org/preview/pandas-dev/pandas/61380/

Thanks@goanpeca for this. Do you mind adding some more context here? I can't see inhttps://github.com/Scientific-Python-Translations/pandas-translations much information, like what languages are available, or how to fix a bad translation, which would be useful to know.

Also, in the docs generated from this PR I can see any language dropdown or anything different from our current docs. What are we expecting?

Hi@datapythonista - this is a follow up to#61220, a proof-of-concept CI job to build the website with translations that don't live in this repo. This PR and#61220 are meant to work together and I'm happy to incorporate one into the other once we agree on the general direction and workflow for this.

Let us know if we can answer any other questions. Unfortunately I'm not sure how to get the preview for the other PR, I relied on building locally to test that things were working.

Sorry, I missed#61220 and the issue discussion.

I don't fully understand what you're doing here, but I describe next how to add translations without adding too much complexity in this repo, which I don't think any core dev would be onboard with.

1. You decide on how to generate translations and manage it independently from this repo, and end up with a structure like this with the translated documents:

+ es/  - index.md  + about/    - team.md    - ...  - ...+ pt/  - index.md  + about/    - team.md    - ...  - ...

2. In our CI, before callingpandas_web.py you download this directory structure to theweb/ directory. No other changes needed, this will create all translated pages.
3. We add a dropdown with the languages to the website (you can add the language list toweb/pandas/config.yml)

I think this makes everyone's life easy, and we get the expected result.

Thanks@datapythonista !

Can you clarify what is missing from#61220 to match your description? That is pretty much what is done in that PR. Maybe this is confusing because we chose to do it in two parts exactly because we wanted to decouple the reorganization of the repo + switcher (in#61220) from the actual translations (this PR).

Happy to follow up with any feedback in the other PR as well. Cheers!

In#61220 you are moving all the current website pages, that should be undone. You are adding the translated pages to this repo, we don't want it. You are making changes to pandas_web.py, this is not needed based on what I described above.

Only changes in a PR to this pandas repo should be addi g a CI step as per step 2, editing the wevsite template with the language dropdown as per step 3.

I see! I will rework what I have there to match your proposal. Thanks!

Great improvement to the PR, this makes a lot of sense to me.

Thanks for the review@datapythonista.

First, if I understand correctly, you download the translations of the web, and the percentage of the translated content, amd then you check for each language if it's translated enough to be published. Personally, I think you should better take care of this logic in your repo when generating the tar, not here. First to simplify the code here, and second to avoid downloading translations that are not going to be used.

Fixed!

Just as a suggestion, I wouldn't use this approach, even in your repo. Imagine you publish translations that are at least 90%, and we have Spanish at 100%. Then I add new content that is 11% of the website. And automatically the Spanish translations that are already indexed by search engines, in user bookmarks, in links in blog posts... are deleted from our website. Not great in my opinion, much better to simply get the new content in English and hope it will eventually be translated.

This is also fixed!

Another thing I would do is to extract the tar file as it is downloaded. So the tar file is passed to gzip/tarfile in memory, with the io module, not as a path in disk. With this you can get all the code here in a single short function. Or we ciuld even create a github action in your repo with this, as it's generic, and just use it here. So only the CI step would live in this PR.

Did not follow this one as I think things are now simpler and in a single script.

Finally, we already have a configuration file for the website. We could save the url of the translations tar there. Also good in the script, just a question of preference. Or if you go for the github action approach, it could simply be a parameter in the CI step. Then you would need another one for the target dir in this repo.

Added the information the to the config file as requested and updated the scripts to handle site generation for languages. Moved all logic to the existing script.

In any case, the approach here is also very reasonable, all above are suggestions that personally I think would make things simpler.

Please let me know what do you think about the current changes.

This PR now supersedes#61220

Thanks@melissawm!

Hi@datapythonista, I implemented the suggestions.

Hi@datapythonista, I implemented most of the additional suggestions. Please see comments.

I'd split the preprocessors in a slightly different way as suggested in the comments, but I think the way the code is now is very simple and easy to understand and maintain. Thanks a lot for all the updates here.

Made some new changes based on your suggestions@datapythonista.

/preview

Website preview of this PR available at:https://pandas.pydata.org/preview/pandas-dev/pandas/61380/

The sponsor logos in the home page don't render correctly. I guess the problem is not in this PR, but in the translation of the html file, no?

The sponsor logos in the home page don't render correctly. I guess the problem is not in this PR, but in the translation of the html file, no?

Would it be ok to use absolute URLs? since the english pages live in the root but the translated pages live ines/something. Would not work on preview though.

I could use/static/img... instead of../static at is currently used. Frameworks rely on filters likerelative_url / absolute_url to handle this cases and append the appropriate base_folder or base_url to the link.

Either that, or copying assets folder into each language.

The images of the books should be implemented in the same exact way, and those seem to be working fine in the translated pages. Doesn't seem like we need to change the links, feels more like a problem in the translated content for those images, no?

The images of the books should be implemented in the same exact way, and those seem to be working fine in the translated pages. Doesn't seem like we need to change the links, feels more like a problem in the translated content for those images, no?

I will look into the content.

I guess the problem is not in this PR, but in the translation of the html file, no?

Correct. This is an issue in the translations. (Working on those fixes)

¿Besides that is there anything else you consider needs a revision?