Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

TST: Testing for mixed int/str Index#61349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xaris96 wants to merge83 commits intopandas-dev:mainfromxaris96:issue-TM

Conversation

xaris96
Copy link

@xaris96xaris96 commentedApr 24, 2025•
edited
Loading

pelagiavlasand others added26 commitsMarch 26, 2025 22:58
@datapythonista
Copy link
Member

@xaris96 Can you fix the broken tests and remove all your debug files from this PR please?

@datapythonistadatapythonista added Testingpandas testing functions or related to the test suite IndexRelated to the Index class or subclasses labelsMay 3, 2025
@datapythonistadatapythonista changed the titleIssue tmTST: Testing for mixed int/str IndexMay 3, 2025
xaris96and others added3 commitsMay 22, 2025 19:30
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@xaris96xaris96 requested a review frommroeschkeMay 23, 2025 07:30
Copy link
Member

@mroeschkemroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please review the diff and consistently use these following conventions

  1. Useinferred_type to check for the newmixed-int-string case you added
  2. If a test fails, do notastype orpytest.skip. Add anpytest.mark.xfail to the test instead

@xaris96xaris96force-pushed theissue-TM branch 6 times, most recently from92e9e10 toa1eed56CompareMay 30, 2025 15:40
@xaris96xaris96 requested a review fromDr-Irv as acode ownerMay 30, 2025 15:40
@xaris96xaris96 requested a review frommroeschkeJune 2, 2025 09:37
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rhshadrachrhshadrachAwaiting requested review from rhshadrach

@Dr-IrvDr-IrvAwaiting requested review from Dr-Irv

@mroeschkemroeschkeAwaiting requested review from mroeschke

Assignees
No one assigned
Labels
IndexRelated to the Index class or subclassesTestingpandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TST: mixed_int_string Index
5 participants
@xaris96@datapythonista@jbrockmendel@mroeschke@pelagiavlas
[8]ページ先頭
©2009-2025 Movatter.jp