Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
TST: Testing for mixed int/str Index#61349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
…t_values_invalid_na_position
…t_values_with_missing
…xes\multi\test_setops.py
@xaris96 Can you fix the broken tests and remove all your debug files from this PR please? |
scripts/cibw_before_test_windows.sh Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This file should have not been changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This file should have not been changed
pandas/tests/window/test_rolling.py Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This file should not have changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, I’m aware — as I mentioned earlier, I ran into an unexpected issue with the test_rolling.py file. It had been working fine before and I hadn’t modified it, so I’m not sure why it started failing. Please let me know if it is a common failure or if there is any other solution for this.
…before_test_windows.sh, undo the test_rolling.py changes
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
| mark=pytest.mark.xfail(reason="complex objects are not comparable") | ||
| request.applymarker(mark) | ||
| request.applymarker(pytest.mark.xfail(reason="GH 14833",strict=False)) | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you remove all thesereturns? We want to apply themark and then let the test run as normal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please review the diff and consistently use these following conventions
- Use
inferred_typeto check for the newmixed-int-stringcase you added - If a test fails, do not
astypeorpytest.skip. Add anpytest.mark.xfailto the test instead
| # special case for mixed types | ||
| ifindex.inferred_type=="mixed": | ||
| index=index.map(str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add anxfail marker here instead?
| if len({type(x) for x in index_with_missing if pd.notna(x)}) > 1: | ||
| index_with_missing = index_with_missing.map(str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please check.inferred_type andxfail if needed.
| non_na_values = [x for x in index_with_missing if pd.notna(x)] | ||
| if len({type(x) for x in non_na_values}) > 1: | ||
| index_with_missing = index_with_missing.map(str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please check.inferred_type andxfail if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you remove this file? These tests are exercised across the test suite
| has_str=any(isinstance(x,str)forxinindex) | ||
| has_int=any(isinstance(x,int)forxinindex) | ||
| ifhas_strandhas_int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please check.inferred_type.
| @pytest.mark.parametrize( | ||
| "index_or_series_obj", [[1,2,3], ["a","b","c"], [0,"a",1,"b",2,"c"]] | ||
| ) | ||
| @pytest.mark.parametrize("sort", [True,False]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| @pytest.mark.parametrize( | |
| "index_or_series_obj", [[1,2,3], ["a","b","c"], [0,"a",1,"b",2,"c"]] | |
| ) | |
| @pytest.mark.parametrize("sort", [True,False]) |
This overrides the original fixtures being used here
| foridxin [index1,index2]: | ||
| forlvlinrange(idx.nlevels): | ||
| ifhas_mixed_types(idx.get_level_values(lvl)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please checkinferred_type
| pytest.skip( | ||
| f"Mixed types in MultiIndex level{lvl} are not orderable" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add anxfail marker instead
Uh oh!
There was an error while loading.Please reload this page.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.