Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
BUG: Fix DatetimeIndex timezone preservation when joining indexes with same timezone but different units#61234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…h same timezone but different units
Hi@rhshadrach, could you please check this one out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@mroeschke - this change will make it so the unit comes out to be the minimum between the two time inputs. Does that look like the correct behavior to you?
Uh oh!
There was an error while loading.Please reload this page.
I agree with@rhshadrach's comment on splitting/parametrizing the test, otherwise this LGTM |
Address review comments on PRpandas-dev#60080 by splitting the comprehensive test intoseparate focused tests for each set operation (union, intersection, symmetric_difference).
Uh oh!
There was an error while loading.Please reload this page.
Hi@rhshadrach, I see that you've requested changes. Could you please clarify what exactly needs to be changed? as I've already made the changes you've requested about |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.