Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bug cov nat#60898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mroeschke merged 13 commits intopandas-dev:mainfromfbourgey:bug-cov-nat
May 23, 2025
Merged

Bug cov nat#60898

mroeschke merged 13 commits intopandas-dev:mainfromfbourgey:bug-cov-nat
May 23, 2025

Conversation

fbourgey
Copy link
Contributor

@WillAydWillAyd added DatetimeDatetime data dtype Missing-datanp.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labelsFeb 14, 2025
@fbourgey
Copy link
ContributorAuthor

@jbrockmendel,@WillAyd, could you please take a look?

Copy link
Member

@WillAydWillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm -@jbrockmendel anything else on your end?

@fbourgey
Copy link
ContributorAuthor

@jbrockmendel, I made the updates

Comment on lines 11356 to 11357
dtypes = [blk.dtype for blk in self._mgr.blocks]
if any(d.kind in "mM" for d in dtypes):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
dtypes= [blk.dtypeforblkinself._mgr.blocks]
ifany(d.kindin"mM"fordindtypes):
ifany(blk.dtype.kindin"mM"forblkinself._mgr.blocks):

@mroeschkemroeschke added this to the3.0 milestoneMay 22, 2025
],
}
)
arr = np.array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
arr=np.array(
expected=np.array(

[np.nan, 8.64e04, 2.00e00],
]
)
assert np.allclose(df.to_numpy(float, na_value=np.nan), arr, equal_nan=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
assertnp.allclose(df.to_numpy(float,na_value=np.nan),arr,equal_nan=True)
result=df.to_numpy(float,na_value=np.nan),
tm.assert_numpy_array_equal(result,expected)

@mroeschkemroeschke merged commitcfe54bd intopandas-dev:mainMay 23, 2025
43 of 44 checks passed
@mroeschke
Copy link
Member

Thanks@fbourgey

@fbourgeyfbourgey deleted the bug-cov-nat branchMay 23, 2025 17:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jbrockmendeljbrockmendeljbrockmendel left review comments

@WillAydWillAydWillAyd approved these changes

@mroeschkemroeschkemroeschke approved these changes

Assignees
No one assigned
Labels
DatetimeDatetime data dtypeMissing-datanp.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: cov buggy when having NaT in column
4 participants
@fbourgey@mroeschke@WillAyd@jbrockmendel
[8]ページ先頭
©2009-2025 Movatter.jp