Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.7k
BUG: Add fillna at the beginning of _where not to fill NA. #60729#60772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sanggon6107 wants to merge38 commits intopandas-dev:mainChoose a base branch fromsanggon6107:add-mask-fillna
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+53 −2
Open
Changes from1 commit
Commits
Show all changes
38 commits Select commitHold shift + click to select a range
bc9a942
BUG: Add fillna so that cond doesnt contain NA at the beginning of _w…
sanggon6107558569f
TST: Add tests for mask with NA. (#60729)
sanggon6107bbbc720
BUG: Fix _where to make np.ndarray mutable. (#60729)
sanggon6107e2f32cb
DOC: Add documentation regarding the bug (#60729)
sanggon61076fd8986
Merge branch 'main' into add-mask-fillna
sanggon6107d2d5f62
ENH: Optimze test_mask_na()
sanggon6107475f2d1
BUG: Fix a bug in test_mask_na() (#60729)
sanggon6107db30b58
Update doc/source/whatsnew/v3.0.0.rst
sanggon610755fe420
Merge branch 'main' into add-mask-fillna
sanggon6107cb94cf7
Add test arguments for test_mask_na
sanggon610771e442e
Fix whatsnew
sanggon6107b6bd3af
Fix test failures by adding importorskip
sanggon61078bac997
Fill True when tuple or list cond has np.nan/pd.NA
sanggon610789bc1b4
Merge branch 'main' into add-mask-fillna
sanggon6107f154cf5
Optimize _where
sanggon6107eed6121
Optimize test_mask_na
sanggon61079ac81f0
Add np.array for read-only ndarray
sanggon61077e3fd3a
Merge branch 'main' into add-mask-fillna
sanggon61078c5ffff
Update generic.py
sanggon61075516517
Revert generic.py
sanggon61072437ce2
Merge branch 'main' into add-mask-fillna
sanggon61079556aa4
Replace np.array with fillna
sanggon6107b64b8a7
Correct the unintended deletion
sanggon61079574746
Merge branch 'main' into add-mask-fillna
sanggon6107c073c0b
Add test for list and ndarray
sanggon61074eea08e
Handle list with NA
sanggon6107bbc5612
Fix code checks
sanggon61070851593
Fix type
sanggon610798fb602
Optimize operation
sanggon6107915b8a7
Prevent a list with np.nan converting to float
sanggon61077611f59
Add test for a list with np.nan
sanggon610788b0530
Merge branch 'main' into add-mask-fillna
sanggon6107044d0a9
fillna after constructor
sanggon6107601f6c9
Parametrize cond type
sanggon61074528a54
Merge branch 'main' into add-mask-fillna
sanggon6107acf805a
Merge branch 'main' into add-mask-fillna
sanggon61073239d2f
Merge branch 'main' into add-mask-fillna
sanggon6107f7a1e5a
Merge branch 'main' into add-mask-fillna
sanggon6107File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Merge branch 'main' into add-mask-fillna
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit88b053060177126c582e577c25bf1366eb07d38f
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.