Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
WEB: Refine PDEP presentation#58791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| h2:hover a.headerlink { | ||
| opacity: 1; | ||
| transition: opacity 0.5s; | ||
| } | ||
| h3:hover a.headerlink { | ||
| opacity: 1; | ||
| transition: opacity 0.5s; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ithink we should be able to combine these two, but wasn't able to figure out the syntax.
| body = markdown.markdown( | ||
| content, extensions=context["main"]["markdown_extensions"] | ||
| ) | ||
| if "pdeps/" in fname: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because of the use ofTocExtension below, we can't use the usual yaml. Not sure if there is a work around or a better approach here.
/preview |
Website preview of this PR available at:https://pandas.pydata.org/preview/pandas-dev/pandas/58791/ |
PDEP6 shows code highlighting. |
@rhshadrach thanks a lot for looking into this! I certainly think this is a nice improvement, and if we don't have agreement on using sphinx instead, we should definitely merge this one. But if you ask my honest opinion, I personally still think#51467 gives the better result. Concrete feedback on the changes here:
|
Aloqeely commentedMay 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Personal preference, but I think the "On this page" sidebar (from@jorisvandenbossche's PR) is cleaner and resembles the docs more than the table of contents here. (I guess that's a benefit of using Sphinx?) |
This pull request is stale because it has been open for thirty days with no activity. Pleaseupdate and respond to this comment if you're still interested in working on this. |
/preview |
@rhshadrach should we merge this? |
/preview |
Website preview of this PR available at:https://pandas.pydata.org/preview/pandas-dev/pandas/58791/ |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Alternative to#51467. I believe this address all items in the linked issue. The main benefit in not switching to publishing PDEPs in sphinx is that it then matches the style of the rest of the webpage.
This is just a rough version to demonstrate what's possible, some refinements (highlighted below) need to be made if we are to merge this.