Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork18.5k
Fix stubname equal suffix in wide to long function#57868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Hi@mroeschke, can you take a look at this PR, please? It should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@tqa236, and sorry for the delay. Not sure if two branches got mixed, seems like half of the changes here are unrelated to the topic of this PR.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
hi@datapythonista, thank you for the review. I also force pushed to the branch because I noticed that you also didn't make any comment on the actual content of the PR. Now this PR should be ready for review. |
Thanks for the update here@tqa236. The fix you implemented seems a hack, not the proper fix. You should identify what's causing the exception, which seem kind of unrelated, and fix that. Please let me know if you want to have a look more in detail to the actual problem, otherwise we can close this PR. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature. (Will add after review)As
pandas
allows an index in a multiindex and a column to have the same name, I think it's reasonable to allow stubname equal suffix.However, I think the root cause is in the
melt
function. It's stated in the docstring thatBut if
value_name == var_name
, illogical result is returned. Example:Result:
I think it's more reasonable to also raise an error if
value_name == var_name
inmelt