Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork16.7k
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implement
provide_automatic_optionsas a regular part of the routing and view dispatch, rather than as a special check on every request.Can be updated to do
except DuplicateRuleErrorinstead ofExceptiononce Werkzeug 3.2 is out. Relies on the duplicate check to not add the internal route multiple times, for example if@app.getand@app.postregister different view functions for the same URL. But nothing breaks if the rule is added multiple times, it's just messy.Adjusts
flask routesto no show the_automatic_optionsendpoint, as that would be really noisy.Also moves the static view out instead of using a lambda and weakref, to match how this new view is handled.
expands on#5917,fixes#5916