Movatterモバイル変換

Skip to content

pallets/flaskPublic

NotificationsYou must be signed in to change notification settings
Fork16.7k
Star71.2k

Comments

type hint fix for flask.send_file#5336

Merged

davidism merged 1 commit intopallets:3.0.xfrom

dannyi96:send_file_fix

Nov 15, 2023

Merged

type hint fix for flask.send_file#5336
davidism merged 1 commit intopallets:3.0.xfrom
dannyi96:send_file_fix

Conversation

@dannyi96

Copy link

Contributor

dannyi96 commentedNov 13, 2023•
edited
Loading

fixesflask.send_file() with Pylance in strict mode shows reportUnknownMemberType #5320

Before

After

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change. --> NA
Add or update relevant docs, in the docs folder and in code. --> NA
Add an entry inCHANGES.rst summarizing the change and linking to the issue -> i believe it's not needed ? let me know if otherwise
Add.. versionchanged:: entries in any relevant code docs -> NA
Runpre-commit hooks and fix any issues.
Runpytest andtox, no tests failed.

@dannyi96

Copy link

ContributorAuthor

dannyi96 commentedNov 14, 2023

@davidism can you review this when possible ? thanks.

davidism

davidism approved these changes

View reviewed changes

@dannyi96

@davidism

type hint fix for flask.send_file

4104f29

@davidism

davidism force-pushed thesend_file_fix branch from7d25ebb to4104f29Compare

November 15, 2023 20:53

@davidism

davidism changed the base branch frommain to3.0.x

November 15, 2023 20:54

@davidism

davidism added this to the3.0.1 milestone

@davidism

davidism added the typing label

@davidism

davidism merged commitb97165d intopallets:3.0.x

@github-actions

github-actionsbot locked asresolvedand limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Labels

2 participants

@dannyi96

@davidism

[8]ページ先頭

©2009-2026 Movatter.jp