Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

Fix teardown bug in FlaskClient#3157

Merged
davidism merged 1 commit intopallets:masterfrom
fantix:fix-test-client-teardown
May 25, 2019
Merged

Fix teardown bug in FlaskClient#3157
davidism merged 1 commit intopallets:masterfrom
fantix:fix-test-client-teardown

Conversation

@fantix
Copy link
Contributor

Entering a client preserves all context from being poped, but exiting only poped one preserved context. This PR pops all preserved context.

@davidismdavidismforce-pushed thefix-test-client-teardown branch from5b97002 toa71c167CompareMay 25, 2019 21:03
@davidismdavidism merged commit2c68f86 intopallets:masterMay 25, 2019
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 14, 2020
@davidism
Copy link
Member

davidism commentedJul 1, 2022•
edited
Loading

This was not actually a bug.stream_with_context preserves a context independently ofwith client, the context should remain until the stream ends or is closed. Either readingresponse.data or callingresponse.close() would be the correct fix to the linked issue.

reverted as part of#4666

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

Testing errors when streaming

2 participants

@fantix@davidism
[8]ページ先頭
©2009-2026 Movatter.jp