Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork16.7k
Comments
Conversation
ThiefMaster commentedJun 2, 2016
second commit should be amended into the first one also, the first line of a commit should be no longer than 51 chars (right not even github truncates it) - seehttp://chris.beams.io/posts/git-commit/ for some useful guidelines |
2e0d78a to0355d93CompareAlso update relevant test
untitaker commentedJun 3, 2016
@ThiefMaster We can squash ourselves so commit styling is no longer that relevant. @jphilipsen05 Can you verify (on your machine) that the tests fail without the bugfix? |
jphilipsen05 commentedJun 3, 2016 • edited by davidism
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by davidism
Uh oh!
There was an error while loading.Please reload this page.
Yes, If I swap the if/elif statements back to the original I get this error in the tests. Showing that the first if statement for aninit.py is hitting the if statement that handles python files and does not reach the expectedinit.py elif statement. When I have my bug fix in place there are no errors. Let me know if you have any other questions. |
There was a bad if/elif statement and the elif os.path ... would never get hit. So I swapped the order of those two statements and added testing for the prepare_exec_for_file function.