Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Clitest update#1872

Merged
untitaker merged 1 commit intopallets:masterfrom
jphilipsen05:clitest_update
Jun 3, 2016
Merged

Clitest update#1872
untitaker merged 1 commit intopallets:masterfrom
jphilipsen05:clitest_update

Conversation

@jphilipsen05
Copy link
Contributor

There was a bad if/elif statement and the elif os.path ... would never get hit. So I swapped the order of those two statements and added testing for the prepare_exec_for_file function.

@ThiefMaster
Copy link
Member

second commit should be amended into the first one

also, the first line of a commit should be no longer than 51 chars (right not even github truncates it) - seehttp://chris.beams.io/posts/git-commit/ for some useful guidelines

@jphilipsen05jphilipsen05force-pushed theclitest_update branch 2 times, most recently from2e0d78a to0355d93CompareJune 2, 2016 23:24
Also update relevant test
@untitaker
Copy link
Contributor

@ThiefMaster We can squash ourselves so commit styling is no longer that relevant.

@jphilipsen05 Can you verify (on your machine) that the tests fail without the bugfix?

@untitakeruntitaker self-assigned thisJun 3, 2016
@jphilipsen05
Copy link
ContributorAuthor

jphilipsen05 commentedJun 3, 2016
edited by davidism
Loading

Yes, If I swap the if/elif statements back to the original I get this error in the tests. Showing that the first if statement for aninit.py is hitting the if statement that handles python files and does not reach the expectedinit.py elif statement.

When I have my bug fix in place there are no errors.

Let me know if you have any other questions.

test_apps = None    def test_prepare_exec_for_file(test_apps):        assert prepare_exec_for_file('test.py') == 'test'>       assert prepare_exec_for_file('/usr/share/__init__.py') == 'share'E       assert '__init__' == 'share'E         - __init__E         + share

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

@untitakeruntitaker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jphilipsen05@ThiefMaster@untitaker

[8]ページ先頭

©2009-2026 Movatter.jp