Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added client encoding to adapted SQL parameters.#159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
osvill wants to merge3 commits intopalewire:main
base:main
Choose a base branch
Loading
fromosvill:fix-dynamic-encoding

Conversation

osvill
Copy link

Fix & test for#158.

@palewire
Copy link
Owner

This is an awesome start. Would it be possible to run a test that raises the encoding error so we can verify the reverse circumstance here?

…cute_sql. It now raises ValueError if client_encoding does not match the database encoding.
@osvill
Copy link
Author

It is hard to catch the error as a specific encoding error. I ended up adding a keyword argumentclient_encoding and raising aValueError ifclient_encoding does not match the database encoding (2nd commit). What do you think?

@osvill
Copy link
Author

I ran some more tests and got errors for adapted parameters that do not have theencoding attribute. Therefore I added thehasattr check and the test filtering by a number in the 3rd commit.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@palewirepalewireAwaiting requested review from palewirepalewire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@osvill@palewire

[8]ページ先頭

©2009-2025 Movatter.jp