- Notifications
You must be signed in to change notification settings - Fork144
feat: ffi verifier cli#265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mikegeeves wants to merge48 commits intopact-foundation:archived/feat/ffi-providerChoose a base branch
base:archived/feat/ffi-provider
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
feat: ffi verifier cli#265
mikegeeves wants to merge48 commits intopact-foundation:archived/feat/ffi-providerfrommikegeeves:feat/ffi-provider-mike
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e changes to docker37 which I will need to do to all
…ing by the tox list)
The return code is straightforward, but having problems with the logging. When setting up the FFIobjects etc, it doesn't seem to work unless it's a basically a singleton, it seems hard to split up.I don't like it but going with this for now :)
Install all ruby standalone packages when running sdist.Devloppers can also now provide a --bin-path that contains the binaries requiredfor their OS, so that can they use this package in offline environments.
…fi_free_string to cleanup
…dation#257)* feat: added support for message provider using pact broker* fix: added new line* fix: update tests to support pact-broker runsfix: updated message_pact to wait writing contract process to finish* fix: removed time from import
Can't see what snyk is complaining about, is it possible to get access or limited number of users etc? |
Hi@mikegeeves, sorry I missed this - have enabled notifications on this repo. Do you need a second pair of eyes or anything over this? |
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Here's where the code is up to, I've merged in recent changes which have gone into master (the updates to setup.py to handle downloading the binaries for example, so the rust ones can then follow the same approach). The CLI is working with the auto-generated click arguments and looks like it works ok, but aware there are concerns with this approach, so pushing over where this is currently up to to figure out what to do next.
Note: this is using a not yet released FFI version, so I was running with a built 0.0.3 FFI from pact-reference