Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/hydraPublic

fix: fosite refresh scope narrowing e2e#3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
james-d-elliott wants to merge5 commits intoory:master
base:master
Choose a base branch
Loading
fromjames-d-elliott:fix-fosite-refresh-scope-narrowing

Conversation

@james-d-elliott
Copy link
Contributor

This is a proof of conformance e2e test for the related issues.

Related issue(s)

ory/fosite#696
ory/fosite#718

Checklist

  • I have read thecontributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read thesecurity policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changedthe documentation.

Further Comments

This is my first time working with cypress, and there may be a better way to handle therefreshTokenBrowserScope or I may have completely bungled it. The intent is for the flow to get an initial refresh token, narrow the scope, then broaden the scope again.

@james-d-elliottjames-d-elliott changed the titleFix fosite refresh scope narrowingfix: fosite refresh scope narrowing e2eJan 2, 2023
@james-d-elliottjames-d-elliottforce-pushed thefix-fosite-refresh-scope-narrowing branch fromfd4ccdc toe9a1358CompareJanuary 2, 2023 08:25
@codecov
Copy link

codecovbot commentedJan 2, 2023
edited
Loading

Codecov Report

Merging#3403 (e9a1358) intomaster (0156556) willdecrease coverage by0.04%.
The diff coverage isn/a.

❗ Current heade9a1358 differs from pull request most recent head322f0a8. Consider uploading reports for the commit322f0a8 to get more accurate results

@@            Coverage Diff             @@##           master    #3403      +/-   ##==========================================- Coverage   76.74%   76.70%   -0.04%==========================================  Files         123      123                Lines        9022     9076      +54     ==========================================+ Hits         6924     6962      +38- Misses       1657     1672      +15- Partials      441      442       +1
Impacted FilesCoverage Δ
driver/registry_sql.go66.99% <0.00%> (-7.21%)⬇️
flow/flow.go92.17% <0.00%> (-1.01%)⬇️
persistence/sql/persister_oauth2.go81.36% <0.00%> (-0.77%)⬇️
client/manager_test_helpers.go98.51% <0.00%> (-0.02%)⬇️
driver/factory.go59.18% <0.00%> (ø)
oauth2/handler.go66.50% <0.00%> (ø)
driver/registry_base.go85.93% <0.00%> (ø)
driver/config/provider.go82.55% <0.00%> (ø)
consent/strategy_default.go69.59% <0.00%> (ø)
jwk/manager_test_helpers.go78.60% <0.00%> (+0.41%)⬆️

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aeneasraeneasrAwaiting requested review from aeneasraeneasr will be requested when the pull request is marked ready for reviewaeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@james-d-elliott

[8]ページ先頭

©2009-2025 Movatter.jp