This update refactorsupdate_grid to detect when a line’s hyperlink structure changes (hyperlink is added or removed) and triggers a full re-render of that line. A newrerender_line method rebuilds the DOM with correct anchor elements for hyperlink groups. If no hyperlink changes are detected, only the modified cells are updated as before.

Emivvvvv added2 commits

May 7, 2025 00:21

fix(DOM): Hyperlinks are overridden when renereded after Paragraph

1c6829f

refactor(DOM): Split grid update logic into two functions

3c09e97

orhun changed the title~~fix(DOM): Hyperlinks are overridden when renereded after Paragraph~~fix(dom): Hyperlinks are overridden when rendered after Paragraph

May 7, 2025

orhun reviewed

May 7, 2025

View reviewed changes

Copy link

Owner

orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good, however I don't understand how this is currently fixing the issue.

It would be really nice if you can explain the problem and solution in detail. This might also lead to a cleaner solution :)

Cargo.toml OutdatedShow resolvedHide resolved

src/backend/dom.rs OutdatedShow resolvedHide resolved

feat(dom): add fn rerender_line() for handling hyperlink changes, imp…

03e2e4e

…rove documentation

Emivvvvv requested a review fromorhun

June 6, 2025 14:33

Copy link

Owner

orhun commentedJun 10, 2025

Thanks for the changes@Emivvvvv! Can you remind me how to test this again? Maybe we should update one of the existing examples to hit this case (so that it's clear that it works). What do you think?

Also did this work for you locally for your website?

Labels

None yet

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(dom): Hyperlinks are overridden when rendered after Paragraph#98

Are you sure you want to change the base?

fix(dom): Hyperlinks are overridden when rendered after Paragraph#98

Uh oh!

Conversation

Emivvvvv commentedMay 6, 2025•
edited
Loading

Uh oh!