Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
DRAFT: Serena Java init_language_server_manager fails for custom gradle setup.#835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
- Check if 'java' key exists in gradle_settings before accessing it- This fixes crash on JDTLS initialization when gradle_java_home is configured- Refs: eclipse_jdtls.py:740
- Document Gradle/JDTLS integration fixes- Show configuration options in ~/.serena/serena_config.yml- Keep note concise and abstract
opcode81 commentedDec 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi Thibault, long time no see! So is the purpose of this PR to provide a basis for a general mitigation strategy that shall be implemented independently, or do you intend to ultimately propose a PR that could be merged? Either way, thanks for trying out Serena and for pointing out the issue. |
tkruse commentedDec 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi Dominik (I was surprised when I realized this project is by you), my first intent was to provide an immediate github fork of Serena that can be installed and used by others in my company, and to get feedback. In the medium term of course I would like to delete my fork again once we found a way to run the JDTLS by Serena with gradle projects in my company, e.g. by merging changes such as those in this MR (or a better fix). At the least I think we would need a way to configure the gradlew wrapper and JRE behavior, and this MR could show a way, though I am not sure whether the MR is good/minimal, I did not have time to polish what the AI produced. |
Uh oh!
There was an error while loading.Please reload this page.
In my company's dev setup serena fails to run the task
init_language_server_managerdue toThe issue is that the sources for our custom plugins are setup in gradlew wrapper.
This PR removes that as a PoC (without consideration of how this breaks for other projects).
The next problem was that in my company, a gradle plugin checks on every gradle run that an approved JRE is being used, while Serena/JDTLS apparently use a fixed JRE. That could be resolved with
ls_specific_settingsinserena_config.yml. The fork for this MR allowed to start serena successfully.This MR is not intended to be merged as is, but only to demonstrate a minimal mitigation that works only within my company.