Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Draft: Feature/svelte support#829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
MischaPanch wants to merge2 commits intomainChoose a base branch fromfeature/svelte_support
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+708 −323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
(allowing the principle upon which the Vue.js implementation is based to beapplied to similar cases)
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like or Feel free to include any additional details that might help me get this PR into a better state. You can manage your notificationsettings |
linxiaotutututu1123 approved these changesDec 11, 2025
linxiaotutututu1123 approved these changesDec 11, 2025
linxiaotutututu1123 approved these changesDec 11, 2025
linxiaotutututu1123 approved these changesDec 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Based on the work of@tylersatre, we can now implement svelte support in a similar way and using the same abstractions as done for vue. Implementing svelte support will also give a practical test for how well the abstractions work (I expect them to work well for this).
Several attempts at supporting svelte were already done in the past, including#339 and#504 .
We can likely reuse a lot of the code there, and combine it with the companion server abstraction introduced on this branch.
I am creating the PR as a place for further discussion and also as a good way for@opcode81 and me to review the companion abstraction.
Thank you@tylersatre for the great work on this, highly appreciated!